Skip to content

Bose landing page#2734

Open
damian-k-dev wants to merge 49 commits intomate-academy:masterfrom
damian-k-dev:develop
Open

Bose landing page#2734
damian-k-dev wants to merge 49 commits intomate-academy:masterfrom
damian-k-dev:develop

Conversation

@damian-k-dev
Copy link

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start :D

  • consider whether header really should be fixed because right now it blends in with the rest of page content which makes it hard to read. fixed header is usually used when it has some background and is clearly separated because content scrolling underneath can reduce readability what can negatively affect user experience. It’s important to ensure proper contrast and visual separation so that header remains clear and accessible

  • remember to build responsive layout from the start. products in recommended section should be centered and/or scale proportionally as screen width changes

@damian-k-dev
Copy link
Author

damian-k-dev commented Mar 7, 2026

Great start :D

  • consider whether header really should be fixed because right now it blends in with the rest of page content which makes it hard to read. fixed header is usually used when it has some background and is clearly separated because content scrolling underneath can reduce readability what can negatively affect user experience. It’s important to ensure proper contrast and visual separation so that header remains clear and accessible
  • remember to build responsive layout from the start. products in recommended section should be centered and/or scale proportionally as screen width changes

Thank you for the feedback :) I have updated header positioning and adjusted the recommended section so the products scale proportionally as the screen width changes

@damian-k-dev
Copy link
Author

Thank you for the feedback :) I have updated header positioning and adjusted the recommended section so the products scale proportionally as the screen width changes

Ok my bad. After coming to the end of building my landing page I realised what you actually meant by saying "remember to build responsive layout from the start". At the beginning I thought it was only about centering the products, but now I understand that I should build responsiveness for each section from the start before moving to the next one.

Now I have to go through each section and adjust the responsiveness which is not ideal, but lesson learned. Next time I will definitely do it from the beginning.. Thanks for pointing this out :D

@damian-k-dev damian-k-dev force-pushed the develop branch 2 times, most recently from 9cbb7b6 to 34a3a66 Compare March 12, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants