Skip to content

Develop#2739

Open
AntoniTS999 wants to merge 12 commits intomate-academy:masterfrom
AntoniTS999:develop
Open

Develop#2739
AntoniTS999 wants to merge 12 commits intomate-academy:masterfrom
AntoniTS999:develop

Conversation

@AntoniTS999
Copy link

Try to create pull-request

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add demo link to pr description

CHECKLIST:

  • Change text color on hover for phone, email and address ("contact us" section)
  • When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
  • When clicking on any location / address - prevent errors and make it to open location in Google Maps
  • Pictures in Gallery should increase on hover
  • Form shouldn't be submitted if some of the fields are not filled
  • disable page scrolling under the menu and ensure that no elements are on the same layer as menu as they remain visible during section navigation
Image

@AntoniTS999
Copy link
Author

AntoniTS999 commented Mar 10, 2026

DEMO LINK

  • Change text color on hover for phone, email and address ("contact us" section) : Added color on hover for input and textarea placeholder

  • When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device : Added href as phone number for links, default decoration of links changed

  • When clicking on any location / address - prevent errors and make it to open location in Google Maps : Added hreff google.map for address line, decoration changed

  • Pictures in Gallery should increase on hover : For each picture on hover, including both "Recommended" and "Browse Bose products by category" sections added transform scale for 20%, moreover by using z-index - pictures on scale are showing above others

  • Form shouldn't be submitted if some of the fields are not filled: For textarea and input (both name and email) added attribute required

  • disable page scrolling under the menu and ensure that no elements are on the same layer as menu as they remain visible during section navigation: Fixed by adding z-index for menu

@AntoniTS999
Copy link
Author

DEMO LINK
Added display block for content (address) to fix the margin-bottom issue

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add transition to image scale effect on hover so interaction feels smoother and prevent image from jumping abruptly

  • titles shouldn't use italic font-style

  • swap hover and default styles for form button to match design

Image
  • scroll is still visible and on tablet/mobile version one image appears on the same layer as menu
Image Image

@AntoniTS999
Copy link
Author

DEMO LINK

  • add transition to image scale effect on hover so interaction feels smoother and prevent image from jumping abruptly: added transition: transform for picture elements for whole layout

  • titles shouldn't use italic font-style: added style: normal

  • swap hover and default styles for form button to match design: changed by dileting modificator primary. Also addded :active for butons

  • scroll is still visible and on tablet/mobile version one image appears on the same layer as menu: added overflow-y and increased z-index to prevent overflowing other elements above menu

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update demo link by running npm run deploy command again

@AntoniTS999
Copy link
Author

Deployed done again.

@AntoniTS999
Copy link
Author

DEMO LINK

@AntoniTS999
Copy link
Author

update demo link by running npm run deploy command again

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants