-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fazendo testes #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fazendo testes #4065
Changes from all commits
e714f02
e90e580
1892180
dcadf7c
b682690
fe35dc6
869f909
04cbe8d
594ba7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test | ||
| - name: Upload HTML report(backstop data) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: backstop_data |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| module.exports = { | ||
| extends: "@mate-academy/stylelint-config", | ||
| plugins: [ | ||
| "stylelint-scss" | ||
| ], | ||
| rules: {} | ||
| extends: '@mate-academy/stylelint-config', | ||
| plugins: ['stylelint-scss'], | ||
| rules: {}, | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,21 @@ | ||
| 'use strict'; | ||
| // https://github.com/garris/BackstopJS#advanced-scenarios | ||
|
|
||
| const backstop = require('@mate-academy/backstop-config'); | ||
| const { basicScenario } = backstop; | ||
|
|
||
| const basic = { | ||
| ...basicScenario, | ||
| url: 'https://johannpdaniel.github.io/layout_stop-watch/', | ||
| referenceUrl: 'https://johannpdaniel.github.io/layout_stop-watch/', | ||
| testUrl: 'https://johannpdaniel.github.io/layout_stop-watch/', | ||
|
Comment on lines
+8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates the previous review correction: "In |
||
| label: 'Elementary test', | ||
| selectors: ['body'], | ||
| removeSelectors: [ | ||
| 'h1', | ||
| ], | ||
| misMatchThreshold: 0.4, | ||
| referenceUrl: basicScenario.referenceUrl + '/stopwatch/', | ||
| }; | ||
|
|
||
| const config = { | ||
| ...backstop, | ||
| fileNameTemplate: '{scenarioLabel}', | ||
| onBeforeScript: 'puppet/onBefore.js', | ||
| onReadyScript: 'puppet/onReady.js', | ||
| viewports: [ | ||
| { | ||
| name: 'tablet_h', | ||
|
|
@@ -40,8 +36,8 @@ const config = { | |
| { | ||
| ...basic, | ||
| label: 'Stopwatch after one circle', | ||
| postDOMChangeWait: 12000, | ||
| } | ||
| postDOMChangeWait: 10000, | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta | ||
| name="viewport" | ||
| content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0" | ||
| /> | ||
| <meta | ||
| http-equiv="X-UA-Compatible" | ||
| content="ie=edge" | ||
| /> | ||
| <title>Stop watch</title> | ||
| <link | ||
| rel="stylesheet" | ||
| href="layout_stop-watch.7ffea227.css" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <div class="stopwatch stopwatch--speed-up"> | ||
| <div class="stopwatch__minutes"></div> | ||
| <div class="stopwatch__seconds"></div> | ||
| </div> | ||
| </body> | ||
| </html> |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file sets
url,referenceUrl, andtestUrltohttps://johannpdaniel.github.io/layout_stop-watch/. This violates the required correction: "backstopConfig.js must not haveurl,referenceUrl, ortestUrlfields hardcoded to another user’s GitHub Pages site (...) ; they must be replaced with the student’s own GitHub Pages URL for this project (e.g.,https://<your_account>.github.io/layout_stop-watch/)". Replace these values with your own GitHub Pages demo URL so Backstop runs against your deployment.