Skip to content

add task solution#4076

Open
Dvoris923 wants to merge 1 commit intomate-academy:masterfrom
Dvoris923:develop
Open

add task solution#4076
Dvoris923 wants to merge 1 commit intomate-academy:masterfrom
Dvoris923:develop

Conversation

@Dvoris923
Copy link

  • DEMO LINK

  • Keyframes implemented using from/to + transform with rotate property

  • Stopwatch is centered and has the correct arrows size

  • All Typical Mistakes from the BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on the stopwatch! Your solution is approved as it meets all the functional and visual requirements using only CSS animations. The BEM structure is well-implemented, and both the standard and speed-up modes work perfectly.

For future improvements, I have two minor suggestions:

  1. In src/styles/index.scss, the CSS properties could be ordered logically as per the style guide (Positioning, Box Model, Visual, etc.). Adhering to this convention ([CHECKLIST ITEM #4]) significantly improves code readability.
  2. The transform: translate(-50%, -100%); declarations on lines 40 and 48 are redundant, as the rotate animation's from keyframe already sets this value. You can remove them to make the code a bit cleaner.

These are just suggestions for refinement. Great job overall!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +40 to +48
transform: translate(-50%, -100%);
animation: rotate 60s linear infinite;
z-index: 2;
}

.stopwatch__hand--minutes {
width: 3vmin;
height: 20vmin;
transform: translate(-50%, -100%);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transform: translate(-50%, -100%); declarations on lines 40 and 48 are redundant. The rotate animation, which is applied immediately, already sets this same transform in its from keyframe. Since the animation's transform property overrides the one set directly on the element, you can safely remove these two lines to make your code a bit cleaner without affecting the functionality.

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants