-
Notifications
You must be signed in to change notification settings - Fork 404
finished #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
finished #345
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,47 @@ | ||
| 'use strict'; | ||
|
|
||
| const http = require('http'); | ||
| const fs = require('fs'); | ||
|
|
||
| function createServer() { | ||
| /* Write your code here */ | ||
| // Return instance of http.Server class | ||
| return http.createServer((req, res) => { | ||
| const normalizedUrl = new URL(req.url, `http://${req.headers.host}`); | ||
| const { pathname } = normalizedUrl; | ||
|
|
||
| if (pathname.includes('//')) { | ||
| res.writeHead(404, { 'Content-Type': 'text/plain' }); | ||
| res.end('File Not Found'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (!pathname.startsWith('/file')) { | ||
| res.writeHead(400, { 'Content-Type': 'text/plain' }); | ||
| res.end('Should be /file/*'); | ||
|
|
||
| return; | ||
|
Comment on lines
+18
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This check |
||
| } | ||
|
|
||
| const relativeFilePath = pathname.replace(/^\/file\/?/, ''); | ||
|
|
||
| if (!relativeFilePath) { | ||
| res.writeHead(200, { 'Content-Type': 'text/plain' }); | ||
| res.end('File Not Found'); | ||
|
|
||
| return; | ||
|
Comment on lines
+27
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When |
||
| } | ||
|
|
||
| fs.readFile(`public/${relativeFilePath}`, (err, data) => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reading |
||
| if (err) { | ||
| res.writeHead(404, { 'Content-Type': 'text/plain' }); | ||
| res.end('File Not Found'); | ||
|
|
||
| return; | ||
| } | ||
| res.writeHead(200, { 'Content-Type': 'text/plain' }); | ||
| res.end(data); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| module.exports = { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pathname.includes('//')check is not sufficient protection against crafted paths (e.g...segments). It's fine to keep as a simple sanity check, but do not rely on it for security — thepath.resolve+path.relativecontainment check is required to guarantee no access outsidepublic.