-
Notifications
You must be signed in to change notification settings - Fork 3.2k
done Add TODO form task #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
done Add TODO form task #3561
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,123 @@ | ||
| import './App.scss'; | ||
|
|
||
| // import usersFromServer from './api/users'; | ||
| // import todosFromServer from './api/todos'; | ||
| import { useState } from 'react'; | ||
|
|
||
| import usersFromServer from './api/users'; | ||
| import todosFromServer from './api/todos'; | ||
|
|
||
| import { TodoList } from './components/TodoList'; | ||
| import { Todo } from './types/Todo'; | ||
| import { User } from './types/User'; | ||
|
|
||
| export const App = () => { | ||
| const [todos, setTodos] = useState<Todo[]>(todosFromServer); | ||
|
|
||
| const [title, setTitle] = useState(''); | ||
| const [selectedUserId, setSelectedUserId] = useState('0'); | ||
|
|
||
| const [titleError, setTitleError] = useState(false); | ||
| const [userError, setUserError] = useState(false); | ||
|
|
||
| const getUserById = (id: number): User => { | ||
| return usersFromServer.find(user => user.id === id) || usersFromServer[0]; | ||
| }; | ||
|
|
||
| const preparedTodos: Todo[] = todos.map(todo => ({ | ||
| ...todo, | ||
| user: getUserById(todo.userId), | ||
| })); | ||
|
|
||
| const generateNewTodoId = () => { | ||
| return todos.length ? Math.max(...todos.map(todoItem => todoItem.id)) + 1 : 1; | ||
| }; | ||
|
|
||
| const resetForm = () => { | ||
| setTitle(''); | ||
| setSelectedUserId('0'); | ||
| setTitleError(false); | ||
| setUserError(false); | ||
| }; | ||
|
|
||
| const handleSubmit = (event: React.FormEvent) => { | ||
| event.preventDefault(); | ||
|
|
||
| const trimmedTitle = title.trim(); | ||
| const isUserSelected = selectedUserId !== '0'; | ||
|
|
||
| setTitleError(!trimmedTitle); | ||
| setUserError(!isUserSelected); | ||
|
|
||
| if (!trimmedTitle || !isUserSelected) { | ||
| return; | ||
| } | ||
|
|
||
| const userIdNumber = Number(selectedUserId); | ||
|
|
||
| const newTodo: Todo = { | ||
| id: generateNewTodoId(), | ||
| title: trimmedTitle, | ||
| completed: false, | ||
| userId: userIdNumber, | ||
| // якщо у твоєму типі Todo поле user опціональне — можна не додавати. | ||
| // Але додати корисно, щоб не було undefined у TodoInfo/UserInfo: | ||
| user: getUserById(userIdNumber), | ||
| }; | ||
|
|
||
| setTodos(currentTodos => [...currentTodos, newTodo]); | ||
| resetForm(); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="App"> | ||
| <h1>Add todo form</h1> | ||
|
|
||
| <form action="/api/todos" method="POST"> | ||
| <div className="field"> | ||
| <input type="text" data-cy="titleInput" /> | ||
| <span className="error">Please enter a title</span> | ||
| <form onSubmit={handleSubmit}> | ||
| <div> | ||
| <label htmlFor="titleInput">Title:</label> | ||
|
|
||
| <input | ||
| id="titleInput" | ||
| type="text" | ||
| data-cy="titleInput" | ||
| placeholder="Enter a title" | ||
| value={title} | ||
| onChange={event => { | ||
| setTitle(event.target.value); | ||
| setTitleError(false); | ||
| }} | ||
| /> | ||
|
|
||
| {titleError && <span className="error">Please enter a title</span>} | ||
| </div> | ||
|
|
||
| <div className="field"> | ||
| <select data-cy="userSelect"> | ||
| <option value="0" disabled> | ||
| Choose a user | ||
| </option> | ||
| <div> | ||
| <label htmlFor="userSelect">User:</label> | ||
|
|
||
| <select | ||
| id="userSelect" | ||
| data-cy="userSelect" | ||
| value={selectedUserId} | ||
| onChange={event => { | ||
| setSelectedUserId(event.target.value); | ||
| setUserError(false); | ||
| }} | ||
| > | ||
| <option value="0">Choose a user</option> | ||
|
|
||
| {usersFromServer.map(user => ( | ||
| <option key={user.id} value={user.id}> | ||
| {user.name} | ||
| </option> | ||
| ))} | ||
| </select> | ||
|
|
||
| <span className="error">Please choose a user</span> | ||
| {userError && <span className="error">Please choose a user</span>} | ||
| </div> | ||
|
|
||
| <button type="submit" data-cy="submitButton"> | ||
| Add | ||
| </button> | ||
| <button type="submit">Add</button> | ||
| </form> | ||
|
|
||
| <section className="TodoList"> | ||
| <article data-id="1" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="15" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="2" className="TodoInfo"> | ||
| <h2 className="TodoInfo__title"> | ||
| quis ut nam facilis et officia qui | ||
| </h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Julianne.OConner@kory.org"> | ||
| Patricia Lebsack | ||
| </a> | ||
| </article> | ||
| </section> | ||
| <TodoList todos={preparedTodos} /> | ||
| </div> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,19 @@ | ||
| export const TodoInfo = () => {}; | ||
| import { UserInfo } from '../UserInfo'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| import { Todo } from '../../types/Todo'; | ||
|
|
||
| interface Props { | ||
| todo: Todo; | ||
| } | ||
|
|
||
| export const TodoInfo = ({ todo }: Props) => { | ||
| return ( | ||
| <article | ||
| data-id={todo.id} | ||
| className={`TodoInfo${todo.completed ? ' TodoInfo--completed' : ''}`} | ||
| > | ||
| <h2 className="TodoInfo__title">{todo.title}</h2> | ||
|
|
||
| <UserInfo user={todo.user} /> | ||
| </article> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,20 @@ | ||
| export const TodoList = () => {}; | ||
| import { Todo } from '../../types/Todo'; | ||
| import { TodoInfo } from '../TodoInfo'; | ||
|
|
||
| type Props = { | ||
| todos?: Todo[]; | ||
| }; | ||
|
|
||
| export const TodoList = ({ todos }: Props) => { | ||
| if (!todos) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <section className="TodoList"> | ||
| {todos.map(todo => ( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates CHECKLIST ITEM #4: "Don't render the component if the property that you pass to the component has There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #4: "Don't render the component if the property that you pass to the component has |
||
| <TodoInfo key={todo.id} todo={todo} /> | ||
| ))} | ||
| </section> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,13 @@ | ||
| export const UserInfo = () => {}; | ||
| import { User } from '../../types/User'; | ||
|
|
||
| interface Props { | ||
| user: User; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The prop is declared as |
||
| } | ||
|
|
||
| export const UserInfo = ({ user }: Props) => { | ||
| return ( | ||
| <a className="UserInfo" href={`mailto:${user.email}`}> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line accesses |
||
| {user.name} | ||
| </a> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { User } from './User'; | ||
|
|
||
| export interface Todo { | ||
| id: number; | ||
| title: string; | ||
| completed: boolean; | ||
| userId: number; | ||
| user: User; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export interface User { | ||
| id: number; | ||
| name: string; | ||
| username: string; | ||
| email: string; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When creating
newTodoyou don't include theuserobject on the todo itself (you only attach users later inprepareTodos). The displayed list will have users, but the todo stored in state lacksuser. If tests or later code expect each todo item in state to include auserobject (as stated in the requirements: "each TODO item must have ... a user object"), consider addinguser: getUserById(+userId)tonewTodoso the state contains fully-prepared todos.