-
Notifications
You must be signed in to change notification settings - Fork 3.2k
added solution #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
added solution #3563
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,122 @@ | ||
| import { FormEvent, useState } from 'react'; | ||
| import './App.scss'; | ||
| import { TodoList } from './components/TodoList'; | ||
|
|
||
| // import usersFromServer from './api/users'; | ||
| // import todosFromServer from './api/todos'; | ||
| import usersFromServer from './api/users'; | ||
| import todosFromServer from './api/todos'; | ||
|
|
||
| import { Todo } from './types/todo'; | ||
| import { User } from './types/User'; | ||
|
|
||
| function getUserById(userId: number): User { | ||
| const user = usersFromServer.find(preson => preson.id === userId); | ||
|
|
||
| if (!user) { | ||
| throw new Error(`User with id ${userId} was not found`); | ||
| } | ||
|
|
||
| return user; | ||
| } | ||
|
|
||
| export const App = () => { | ||
| const [title, setTitle] = useState(''); | ||
| const [titleError, setTitleError] = useState(false); | ||
| const [selectedUserId, setSelectedUserId] = useState(''); | ||
| const [userError, setUserError] = useState(false); | ||
| const [todos, setTodos] = useState<Todo[]>( | ||
| todosFromServer.map(todo => ({ | ||
| ...todo, | ||
| user: getUserById(todo.userId), | ||
| })), | ||
| ); | ||
|
|
||
| const handleSubmit = (event: FormEvent<HTMLFormElement>) => { | ||
| event.preventDefault(); | ||
|
|
||
| const hasTitle = title.trim().length > 0; | ||
| const hasSelectedUser = selectedUserId !== ''; | ||
|
|
||
| if (!hasTitle) { | ||
| setTitleError(true); | ||
| } | ||
|
|
||
| if (!hasSelectedUser) { | ||
| setUserError(true); | ||
| } | ||
|
|
||
| if (!hasTitle || !hasSelectedUser) { | ||
| return; | ||
| } | ||
|
|
||
| const userId = +selectedUserId; | ||
| const user = getUserById(userId); | ||
| const maxTodoId = | ||
| todos.length > 0 ? Math.max(...todos.map(todo => todo.id)) : 0; | ||
|
|
||
| const newTodo: Todo = { | ||
| id: maxTodoId + 1, | ||
| title: title.trim(), | ||
| userId, | ||
| completed: false, | ||
| user, | ||
| }; | ||
|
|
||
| setTodos(currentTodos => [...currentTodos, newTodo]); | ||
| setTitle(''); | ||
| setSelectedUserId(''); | ||
| setTitleError(false); | ||
| setUserError(false); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="App"> | ||
| <h1>Add todo form</h1> | ||
|
|
||
| <form action="/api/todos" method="POST"> | ||
| <form onSubmit={handleSubmit}> | ||
| <div className="field"> | ||
| <input type="text" data-cy="titleInput" /> | ||
| <span className="error">Please enter a title</span> | ||
| <label htmlFor="title">Title:</label> | ||
| <input | ||
| id="title" | ||
| type="text" | ||
| placeholder="Enter a title" | ||
| data-cy="titleInput" | ||
| value={title} | ||
| onChange={event => { | ||
| setTitle(event.target.value); | ||
| setTitleError(false); | ||
| }} | ||
| /> | ||
| {titleError && <span className="error">Please enter a title</span>} | ||
| </div> | ||
|
|
||
| <div className="field"> | ||
| <select data-cy="userSelect"> | ||
| <option value="0" disabled> | ||
| Choose a user | ||
| </option> | ||
| <label htmlFor="userId">User:</label> | ||
| <select | ||
| id="userId" | ||
| data-cy="userSelect" | ||
| value={selectedUserId} | ||
| onChange={event => { | ||
| setSelectedUserId(event.target.value); | ||
| setUserError(false); | ||
| }} | ||
| > | ||
| <option value="">Choose a user</option> | ||
| {usersFromServer.map(user => ( | ||
| <option value={user.id} key={user.id}> | ||
| {user.name} | ||
| </option> | ||
| ))} | ||
| </select> | ||
|
|
||
| <span className="error">Please choose a user</span> | ||
| {userError && <span className="error">Please choose a user</span>} | ||
| </div> | ||
|
|
||
| <button type="submit" data-cy="submitButton"> | ||
| Add | ||
| </button> | ||
| </form> | ||
|
|
||
| <section className="TodoList"> | ||
| <article data-id="1" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="15" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="2" className="TodoInfo"> | ||
| <h2 className="TodoInfo__title"> | ||
| quis ut nam facilis et officia qui | ||
| </h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Julianne.OConner@kory.org"> | ||
| Patricia Lebsack | ||
| </a> | ||
| </article> | ||
| </section> | ||
| <TodoList todos={todos} /> | ||
| </div> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,23 @@ | ||
| export const TodoInfo = () => {}; | ||
| import { UserInfo } from '../../components/UserInfo'; | ||
| import { Todo } from '../../types/todo'; | ||
| import classNames from 'classnames'; | ||
|
|
||
| type Props = { | ||
| todo: Todo; | ||
| }; | ||
|
|
||
| export const TodoInfo = ({ todo }: Props) => { | ||
| return ( | ||
| <article | ||
| data-id={todo.id} | ||
| className={classNames('TodoInfo', { | ||
| 'TodoInfo--completed': todo.completed, | ||
| })} | ||
| key={todo.id} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||
| > | ||
| <h2 className="TodoInfo__title">{todo.title}</h2> | ||
|
|
||
| <UserInfo user={todo.user} /> | ||
| </article> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,14 @@ | ||
| export const TodoList = () => {}; | ||
| import { Todo } from '../../types/todo'; | ||
| import { TodoInfo } from '../TodoInfo'; | ||
|
|
||
| interface Props { | ||
| todos: Todo[]; | ||
| } | ||
|
|
||
| export const TodoList = ({ todos }: Props) => ( | ||
| <section className="TodoList"> | ||
| {todos.map(todo => ( | ||
| <TodoInfo todo={todo} key={todo.id} /> | ||
| ))} | ||
| </section> | ||
| ); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,13 @@ | ||
| export const UserInfo = () => {}; | ||
| import { User } from '../../types/User'; | ||
|
|
||
| interface Props { | ||
| user: User; | ||
| } | ||
|
|
||
| export const UserInfo = ({ user }: Props) => { | ||
| return ( | ||
| <a className="UserInfo" href={`mailto:${user.email}`}> | ||
| {user.name} | ||
| </a> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { User } from './User'; | ||
|
|
||
| export interface Todo { | ||
| id: number; | ||
| title: string; | ||
| completed: boolean; | ||
| userId: number; | ||
| user: User; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export interface User { | ||
| id: number; | ||
| name: string; | ||
| username: string; | ||
| email: string; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor typo. It looks like
presonshould bepersonfor better clarity.