-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Develop #3572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #3572
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,101 @@ | ||
| import './App.scss'; | ||
| import { TodoList } from './components/TodoList'; | ||
| import usersFromServer from './api/users'; | ||
| import todosFromServer from './api/todos'; | ||
| import { Todo, User } from './types/types'; | ||
| import { useState } from 'react'; | ||
|
|
||
| // import usersFromServer from './api/users'; | ||
| // import todosFromServer from './api/todos'; | ||
| const getUserById = (userId: number): User | null => { | ||
| return usersFromServer.find((user: User) => user.id === userId) || null; | ||
| }; | ||
|
|
||
| const getTodoWithUser = (todo: Omit<Todo, 'user'>): Todo => { | ||
| return { ...todo, user: getUserById(todo.userId) }; | ||
| }; | ||
|
|
||
| const initialTodos = todosFromServer.map(getTodoWithUser); | ||
|
|
||
| export const App = () => { | ||
| const [todos, setTodos] = useState(initialTodos); | ||
| const [title, setTitle] = useState(''); | ||
| const [userId, setUserId] = useState(0); | ||
| const [titleError, setTitleError] = useState(false); | ||
| const [userError, setUserError] = useState(false); | ||
|
|
||
| const handleSubmit = (event: React.FormEvent) => { | ||
| event.preventDefault(); | ||
|
|
||
| if (!title) { | ||
| setTitleError(true); | ||
| } | ||
|
|
||
| if (!userId) { | ||
| setUserError(true); | ||
| } | ||
|
|
||
| if (!title || !userId) { | ||
| return; | ||
| } | ||
|
|
||
| const newTodo: Todo = { | ||
| id: todos.length > 0 ? Math.max(...todos.map(todo => todo.id)) + 1 : 1, | ||
| title, | ||
| userId, | ||
| completed: false, | ||
| user: getUserById(userId), | ||
| }; | ||
|
|
||
| setTodos([...todos, newTodo]); | ||
| setTitle(''); | ||
| setUserId(0); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="App"> | ||
| <h1>Add todo form</h1> | ||
|
|
||
| <form action="/api/todos" method="POST"> | ||
| <form onSubmit={handleSubmit}> | ||
| <div className="field"> | ||
| <input type="text" data-cy="titleInput" /> | ||
| <span className="error">Please enter a title</span> | ||
| <input | ||
| type="text" | ||
| data-cy="titleInput" | ||
| value={title} | ||
| placeholder="Enter a title" | ||
| onChange={event => { | ||
| setTitle(event.target.value); | ||
| setTitleError(false); | ||
| }} | ||
| /> | ||
| {titleError && <span className="error">Please enter a title</span>} | ||
| </div> | ||
|
|
||
| <div className="field"> | ||
| <select data-cy="userSelect"> | ||
| <select | ||
| data-cy="userSelect" | ||
| value={userId} | ||
| onChange={event => { | ||
| setUserId(+event.target.value); | ||
| setUserError(false); | ||
| }} | ||
| > | ||
| <option value="0" disabled> | ||
| Choose a user | ||
| </option> | ||
| {usersFromServer.map(user => ( | ||
| <option key={user.id} value={user.id}> | ||
| {user.name} | ||
| </option> | ||
| ))} | ||
| </select> | ||
|
|
||
| <span className="error">Please choose a user</span> | ||
| {userError && <span className="error">Please choose a user</span>} | ||
| </div> | ||
|
|
||
| <button type="submit" data-cy="submitButton"> | ||
| Add | ||
| </button> | ||
| </form> | ||
|
|
||
| <section className="TodoList"> | ||
| <article data-id="1" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="15" className="TodoInfo TodoInfo--completed"> | ||
| <h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
| Leanne Graham | ||
| </a> | ||
| </article> | ||
|
|
||
| <article data-id="2" className="TodoInfo"> | ||
| <h2 className="TodoInfo__title"> | ||
| quis ut nam facilis et officia qui | ||
| </h2> | ||
|
|
||
| <a className="UserInfo" href="mailto:Julianne.OConner@kory.org"> | ||
| Patricia Lebsack | ||
| </a> | ||
| </article> | ||
| </section> | ||
| <TodoList todos={todos} /> | ||
| </div> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,21 @@ | ||
| export const TodoInfo = () => {}; | ||
| import { UserInfo } from '../UserInfo'; | ||
| import { Todo } from '../../types/types'; | ||
|
|
||
| type Props = { | ||
| todo: Todo; | ||
| }; | ||
|
|
||
| export const TodoInfo = ({ todo }: Props) => { | ||
| return ( | ||
| <> | ||
| <article | ||
| data-id={todo.id} | ||
| className={`TodoInfo ${todo.completed ? 'TodoInfo--completed' : ''}`} | ||
| > | ||
| <h2 className="TodoInfo__title">{todo.title}</h2> | ||
|
|
||
| {todo.user && <UserInfo user={todo.user} />} | ||
| </article> | ||
| </> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,12 @@ | ||
| export const TodoList = () => {}; | ||
| import { TodoInfo } from '../TodoInfo'; | ||
| import { Props } from '../../types/types'; | ||
|
|
||
| export const TodoList = ({ todos }: Props) => { | ||
| return ( | ||
| <section className="TodoList"> | ||
| {todos.map(todo => ( | ||
| <TodoInfo key={todo.id} todo={todo} /> | ||
| ))} | ||
| </section> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,13 @@ | ||
| export const UserInfo = () => {}; | ||
| import { User } from '../../types/types'; | ||
|
|
||
| type Props = { | ||
| user: User; | ||
| }; | ||
|
|
||
| export const UserInfo = ({ user }: Props) => { | ||
| return ( | ||
| <a className="UserInfo" href={`mailto:${user.email}`}> | ||
| {user.name} | ||
| </a> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export type User = { | ||
| id: number; | ||
| name: string; | ||
| username: string; | ||
| email: string; | ||
| }; | ||
|
|
||
| export type Todo = { | ||
| id: number; | ||
| title: string; | ||
| completed: boolean; | ||
| userId: number; | ||
| user: User | null; | ||
| }; | ||
|
|
||
| export type Props = { | ||
| todos: Todo[]; | ||
| }; | ||
|
Comment on lines
+16
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good practice to define component-specific props within the component's file. The
Propstype defined intypes/types.tsis only used byTodoList. It would be better to move this type definition into this file to make the component more self-contained. Thetypes.tsfile should be reserved for types that are shared across multiple components, such asTodoandUser.