Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Your implementation of the App component is mostly correct and meets the core requirements of the task. 🎉 There are a few minor improvements you could consider for future enhancements, such as renaming the clearState method to clearSelection for better clarity and avoiding inline event handlers for better performance. Additionally, setting selectedGood to null instead of an empty string can make your code more intuitive. Keep up the great work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <tbody> | ||
| {goods.map(good => { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
The use of fragments (<> </>) here is unnecessary since there is only one child element (<tr>). You can remove the fragments to simplify the code.
| </button> | ||
| </td> | ||
| clearState = () => { | ||
| this.setState({ selectedGood: '' }); |
There was a problem hiding this comment.
Consider setting selectedGood to null instead of an empty string for clarity when clearing the state. This can make the intent clearer and avoid potential confusion with string operations.
2 participants
DEMO LINK