Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Great job on meeting the task requirements! 🎉 The code in App.tsx functions well and aligns with the task constraints. While there are minor issues, such as the self-closing <button> tag and the className consistency for the <td> element, these do not impact the core functionality. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| onClick={() => setSelectedGood('')} | ||
| /> |
There was a problem hiding this comment.
The <button> element should not be self-closing. It should have an opening and a closing tag, even if it does not contain any children. Change it to <button ...></button>.
| </button> | ||
| )} | ||
| </td> | ||
| <td data-cy="GoodTitle" className="is-vcentered"> |
There was a problem hiding this comment.
Ensure that the className for the <td> element is consistent with the rest of the code. Currently, it uses is-vcentered, which should be verified for its intended use and consistency.
2 participants
[DEMO LINK](https://TomaszKrzywicki.github.io/react_goods-selector/