Skip to content

task solution#1787

Open
KrawczykDamiann wants to merge 1 commit intomate-academy:masterfrom
KrawczykDamiann:develop
Open

task solution#1787
KrawczykDamiann wants to merge 1 commit intomate-academy:masterfrom
KrawczykDamiann:develop

Conversation

@KrawczykDamiann
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job! 🎉 Your implementation meets all the core requirements and functions as expected. The only minor issue is the deprecated 'jsx' value in tsconfig.json, but this does not affect the main functionality of your code. For future projects, consider updating it to 'react-jsx' if you're using React 17+, but no changes are needed for this task. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

"src"
],
"compilerOptions": {
"jsx": "react",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value 'react' for the 'jsx' compiler option is deprecated in newer TypeScript versions. If you are using React 17 or later, you should use 'react-jsx' instead, as per the TypeScript documentation. Please update this option if your project uses a recent React version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants