Conversation
2pasha
left a comment
There was a problem hiding this comment.
good progress! 🚀
last improvements:
- fix linter errors
- take a look on scroll to top behavior, ex: user scroll catalog -> click on some Product -> ProductDetailPage is not scrolled up
|
Fixed linter issues and CI test script. |
|
hi. okay, i‘ll fix this
maybe u can also give me another changes? cause i think will be better if i
do all changes in one session?
нд, 22 лют. 2026 р. о 11:30 Denys Semtso ***@***.***> пише:
… ***@***.**** requested changes on this pull request.
1. after selecting a product, the page should scroll up to avoid this
situation
(this is the view after selecting a product)
image.png (view on web)
<https://github.com/user-attachments/assets/8bd4c5d7-c5aa-4c30-92d6-b3c5ba27ff7d>
2. it would be great if you could add a 'you may also like' section
—
Reply to this email directly, view it on GitHub
<#895 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B4J7IHY6IX5BRNRZQ3D2CNT4NFZLHAVCNFSM6AAAAACVV7OAZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMZXGEYDQMJQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
vitalii-bondarenko-ua
left a comment
There was a problem hiding this comment.
-
Catalog page has horizontal scroll on some cases. See video.
The reason is navigation. Think how to reduce number of pages (not show all pages, just first, last and few around current page) -
content should be centered horizontally
-
strange behavior with dropdown on mobile. It aprears in other place then dropdown title.
Screen.Recording.2026-02-22.at.20.25.10.mov
brespect
left a comment
There was a problem hiding this comment.
Good progress, let`s check next:
- Remove button must completely remove item from Product Cart, not decrease the quantity.
-
Remove markings at the top of the header how many products are currently in the Product Cart and Favourites, when quantity is equal to 0.
-
I also saw the idea that when I select an item, the browser title changes, but when I, for example, go from the producer details page with any of the iPhones to the page with the producer card, the name of the phone remains in the title, even though I'm on a completely different page.
-
Pagination better to be at the bottom of page every time, for prevent case like this:
c9361a7 to
516fba7
Compare
|
@etojeDenys @2pasha @brespect @vitalii-bondarenko-ua this PR closed after force push (i want to do clean work place but had some problems). can u check please that branch? #907 . Thank you. |

Demo:
https://sashkatmshchk-pixel.github.io/react_phone-catalog/
Hi! Final version ready for review.
All mentor fixes applied:
Ready for final review