Skip to content

Solution#895

Closed
sashkatmshchk-pixel wants to merge 2 commits intomate-academy:masterfrom
sashkatmshchk-pixel:solution
Closed

Solution#895
sashkatmshchk-pixel wants to merge 2 commits intomate-academy:masterfrom
sashkatmshchk-pixel:solution

Conversation

@sashkatmshchk-pixel
Copy link

@sashkatmshchk-pixel sashkatmshchk-pixel commented Feb 19, 2026

Demo:
https://sashkatmshchk-pixel.github.io/react_phone-catalog/

Hi! Final version ready for review.

All mentor fixes applied:

  • newest sorting fixed
  • correct back navigation
  • dynamic document title update
  • UI fixes and cleanup
  • project builds and works correctly

Ready for final review

Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress! 🚀

last improvements:

  • fix linter errors
  • take a look on scroll to top behavior, ex: user scroll catalog -> click on some Product -> ProductDetailPage is not scrolled up

@sashkatmshchk-pixel
Copy link
Author

Fixed linter issues and CI test script.
Scroll behavior fixed.
Ready for final review

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. after selecting a product, the page should scroll up to avoid this situation
    (this is the view after selecting a product)
Image
  1. it would be great if you could add a 'you may also like' section

@sashkatmshchk-pixel
Copy link
Author

sashkatmshchk-pixel commented Feb 22, 2026 via email

Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Catalog page has horizontal scroll on some cases. See video.
    The reason is navigation. Think how to reduce number of pages (not show all pages, just first, last and few around current page)

  • content should be centered horizontally

  • strange behavior with dropdown on mobile. It aprears in other place then dropdown title.

Screen.Recording.2026-02-22.at.20.25.10.mov

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s check next:

  1. Remove button must completely remove item from Product Cart, not decrease the quantity.
Image
  1. Remove markings at the top of the header how many products are currently in the Product Cart and Favourites, when quantity is equal to 0.

  2. I also saw the idea that when I select an item, the browser title changes, but when I, for example, go from the producer details page with any of the iPhones to the page with the producer card, the name of the phone remains in the title, even though I'm on a completely different page.

  3. Pagination better to be at the bottom of page every time, for prevent case like this:

Image

@sashkatmshchk-pixel
Copy link
Author

@etojeDenys @2pasha @brespect @vitalii-bondarenko-ua this PR closed after force push (i want to do clean work place but had some problems). can u check please that branch? #907 . Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants