Skip to content

Tasks Solution#899

Open
Vovanchu wants to merge 24 commits intomate-academy:masterfrom
Vovanchu:develop
Open

Tasks Solution#899
Vovanchu wants to merge 24 commits intomate-academy:masterfrom
Vovanchu:develop

Conversation

@Vovanchu
Copy link

No description provided.

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but let's add DEMO LINK to the description and pass all tests before requesting mentor's review

@Vovanchu
Copy link
Author

Vovanchu commented Feb 23, 2026

DemoLink

чому на демолінк, мені не завантажуються сторнки?

@Vovanchu Vovanchu requested a review from brespect February 23, 2026 16:39
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, that issue (page not found) looks triggered by using BrowserRouter instead of HashRouter

GitHub Pages hosting works too bad with BrowserRouter, would you mind to use HashRouter and re-deploy your solution?

Image

Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something really bad happens with your page 😨

Image

please fix this

if you have some troubles - feel free to ask your question in fe_chat 💬

@Vovanchu
Copy link
Author

And how I can fix it???(((

@Vovanchu Vovanchu requested a review from 2pasha March 4, 2026 16:46
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. after pressing the 'add' button, the user should not be redirected to the cart
Image
  1. it would be nice to be able to remove the product by pressing the button again
Image
  1. font looks different here
Image
  1. add a hover effect to these images( for example increase the scale slightly)
Image
  1. these links should not lead to an error page
Image
  1. the page number should not change after the page is reloaded
Image
  1. make sure you also increase these values
Image
  1. you should also increase these numbers
Image

@Vovanchu Vovanchu requested a review from etojeDenys March 5, 2026 14:33
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

To improve:

  1. Add favicon and title to your solution.
  2. Those numbers should be synced (tooltip in the top corner of cart icon should be calculated as sum of all goods in the cart, not only the existing number of different goods:
Image
  1. Styles on the right side of the header nav looks sligthly broken, would you mind to fix them?

@Vovanchu Vovanchu requested a review from Anton-Kuchmasov March 5, 2026 16:54
Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
Let`s just fix few details:

1.Add hover :
Image
Image

  1. Add favicon and title:
Image

3.Space between 'Hot price' and 'Shop by category' shuld be smaller
Image

4.the indicators look strange, and the header itself has some padding on the sides:
Image
Image

@Vovanchu Vovanchu requested a review from FaiHamid March 6, 2026 09:41
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this link should not lead to an error page
Image
  1. place the buttons on the same line
Image
  1. it should link to the product page
Image
  1. font looks different
Image

@Vovanchu Vovanchu requested a review from etojeDenys March 6, 2026 11:55
Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Almost done.

  • fix slider. it has some shift during scrolling. After change slides should be visible 4 slides. fix spacing between slides according to design
Image Image Image
  • font in some places not matches to design.
Image
  • some images are broken and pay attenion on title font.
Image
  • some colors in dots doesn't match real product color.
Image

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Before preparing to Final Review, please make one tiny fix. Check out video below:
https://www.loom.com/share/655b74a1720e43e1b0e87d727990f233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants