Skip to content

phone-catalog_0.1#905

Open
Vlshedevr wants to merge 5 commits intomate-academy:masterfrom
Vlshedevr:develop
Open

phone-catalog_0.1#905
Vlshedevr wants to merge 5 commits intomate-academy:masterfrom
Vlshedevr:develop

Conversation

@Vlshedevr
Copy link

No description provided.

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, now deploy seems broken, please fix all issues, make a new deployment and then re-request review again
If you're stuck, feel free to ask in fe_chat

Image

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you forgot to re-deploy your solution after making changes
please make npm run deploy and double-check is everything is OK

Image

@Vlshedevr
Copy link
Author

Виправив :) https://vlshedevr.github.io/react_phone-catalog/

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link looks broken. please fix it and request the review again

Image Image

@Vlshedevr Vlshedevr requested a review from etojeDenys March 2, 2026 14:50
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Before final review, it's better to make main slider loop - just a suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants