Conversation
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- make sure that your deploy configured well, here should be home page
- fix issue with images
- take a look on comments below ⬇️
src/components/Filter/Filter.tsx
Outdated
| <option value="4" className={styles.option}> | ||
| 4 | ||
| </option> | ||
| <option value="8" className={styles.option}> | ||
| 8 | ||
| </option> | ||
| <option value="16" className={styles.option}> | ||
| 16 | ||
| </option> | ||
| <option value="all" className={styles.option}> | ||
| all | ||
| </option> |
There was a problem hiding this comment.
move it to some variable and map though it
src/components/Logo/logo.tsx
Outdated
| const { theme } = useContext(AppSettingsContext); | ||
|
|
||
| return ( | ||
| <a href="https://github.com/Radymyr" className={styles.logo}> |
There was a problem hiding this comment.
logo should redirect to home page, not to your GH profile
| onClick={() => { | ||
| setPage( | ||
| Number(currentPage) + 1 > totalPages | ||
| ? totalPages | ||
| : currentPage + 1, | ||
| ); |
| onSwiper={swiper => { | ||
| handleButtons(swiper); | ||
| swiperRef.current = swiper; | ||
| }} |
src/Root.tsx
Outdated
| @@ -0,0 +1,64 @@ | |||
| import { | |||
| BrowserRouter as Router, | |||
src/Root.tsx
Outdated
| <AppSettingsProvider> | ||
| <GlobalStateProvider> | ||
| <Routes> | ||
| {/*<Route path={routes.menu} element={<Menu />} />*/} |
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, let`s check next:
- Add favicon and title to browser tab.
- All links in Footer should be real links to existing resourses:
- When you click the favourites button it resizes, it shoulds.
- Make header sticky at the top of the page.
…row button; header men
FaiHamid
left a comment
FaiHamid
left a comment
There was a problem hiding this comment.
Good job!
Let`s just add a few fixes:
- Add width limits to the content (max-width: 1136px)
2.Reduce the hover effect on these images, as they overlap with each other.
3.Add cursor: pointer to these buttons
4.The footer should be fixed to the bottom of the page
FaiHamid
left a comment
FaiHamid
left a comment
There was a problem hiding this comment.
Good progress!
Just few more changes:
1.Second click on this button shoud remove item from cart
2.It should have no overlays
3.Aside`s menu content should be slightly higher, and remove some unnecessary space
4.After clicking these buttons should redirect to favorites and cart
5.On desktop aside menu should close
…ger menu;redirect to favorites and cart; close menu on desktop;
5 participants
https://radymyr.github.io/react_phone-catalog/