Open
Conversation
FaiHamid
suggested changes
Feb 26, 2026
FaiHamid
left a comment
There was a problem hiding this comment.
Hi,
Add DEMO_LINK to pull requet`s description and request mentor review again.
brespect
suggested changes
Feb 27, 2026
brespect
suggested changes
Mar 2, 2026
brespect
left a comment
There was a problem hiding this comment.
Not all comment from my previous review were fixed, also try to pass all CI checks
2pasha
suggested changes
Mar 3, 2026
Comment on lines
+81
to
+86
| options={[ | ||
| 'Newest', | ||
| 'Oldest', | ||
| 'Price: Low to High', | ||
| 'Price: High to Low', | ||
| ]} |
src/components/Phone/Phone.tsx
Outdated
Comment on lines
+15
to
+19
| type SortOption = | ||
| | 'Newest' | ||
| | 'Oldest' | ||
| | 'Price: Low to High' | ||
| | 'Price: High to Low'; |
There was a problem hiding this comment.
make is as an enum and import/export it where you need it
Comment on lines
+292
to
+295
| ['Screen', product.screen], | ||
| ['Resolution', product.resolution], | ||
| ['Processor', product.processor], | ||
| ['RAM', product.ram], |
There was a problem hiding this comment.
it's better to move it to separate value
| ['Built in memory', product.capacity], | ||
| ['Camera', product.camera], | ||
| ['Zoom', product.zoom], | ||
| ['Cell', product.cell.join(', ')], |
etojeDenys
suggested changes
Mar 4, 2026
brespect
suggested changes
Mar 4, 2026
brespect
suggested changes
Mar 5, 2026
brespect
left a comment
There was a problem hiding this comment.
Almost done, please, fix all tests before requesting the review
Denys-Kravchuk9988
suggested changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.












DEMO LINK