Skip to content

complete#908

Open
Yankee33 wants to merge 15 commits intomate-academy:masterfrom
Yankee33:develop
Open

complete#908
Yankee33 wants to merge 15 commits intomate-academy:masterfrom
Yankee33:develop

Conversation

@Yankee33
Copy link

@Yankee33 Yankee33 commented Feb 26, 2026

Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Add DEMO_LINK to pull requet`s description and request mentor review again.

@Yankee33 Yankee33 requested a review from FaiHamid February 26, 2026 20:52
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s fix next:

  1. On every Product Item I get this page:
Image
  1. Footer should be at the bottom of page every time, even when content doesn`t exist.

  2. Let`s center this image:

Image
  1. Add the hover effect to all pictures in Shop by category section.

@Yankee33 Yankee33 requested a review from brespect February 28, 2026 21:16
Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix previos comments!

@Yankee33 Yankee33 requested a review from FaiHamid March 1, 2026 18:14
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all comment from my previous review were fixed, also try to pass all CI checks

@Yankee33 Yankee33 requested a review from brespect March 2, 2026 21:12
Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. fix scroll to top when user enter on new page

Image

  1. i suppose sorting by year doesn't work good
Image Image
  1. user should have ability to open ProductDetailPage from Cart
Image
  1. fix comments below

Comment on lines +81 to +86
options={[
'Newest',
'Oldest',
'Price: Low to High',
'Price: High to Low',
]}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to move to separate value

Comment on lines +15 to +19
type SortOption =
| 'Newest'
| 'Oldest'
| 'Price: Low to High'
| 'Price: High to Low';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make is as an enum and import/export it where you need it

Comment on lines +292 to +295
['Screen', product.screen],
['Resolution', product.resolution],
['Processor', product.processor],
['RAM', product.ram],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to move it to separate value

['Built in memory', product.capacity],
['Camera', product.camera],
['Zoom', product.zoom],
['Cell', product.cell.join(', ')],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

@Yankee33 Yankee33 requested a review from 2pasha March 3, 2026 20:22
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. i can add two of the same product to the cart
Image

firstly, I am adding from here

Image

then I can add again from here
Image

@Yankee33 Yankee33 requested a review from etojeDenys March 4, 2026 11:52
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, check this:

  1. When you select something in this section, the page should smoothly srcolls to the top:
Image 2: Pass all tests and linter checks before requesting the mentor`s review.

@Yankee33 Yankee33 requested a review from brespect March 4, 2026 21:29
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, please, fix all tests before requesting the review

@Yankee33 Yankee33 requested a review from brespect March 5, 2026 17:33
Copy link

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. The images on slider are cropped
Image
  1. I can't open the page on some phone from Favourites page
Image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants