Skip to content

Develop#910

Open
lkovbasiuk wants to merge 9 commits intomate-academy:masterfrom
lkovbasiuk:develop
Open

Develop#910
lkovbasiuk wants to merge 9 commits intomate-academy:masterfrom
lkovbasiuk:develop

Conversation

@lkovbasiuk
Copy link

@lkovbasiuk lkovbasiuk commented Feb 28, 2026

Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Please, add DEMO_LINK to pull request`s description, then re-request review.

@lkovbasiuk lkovbasiuk requested a review from FaiHamid March 1, 2026 16:41
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your page looks completely broken, also try to pass all CI checks:
Image

@lkovbasiuk lkovbasiuk requested a review from brespect March 2, 2026 12:20
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with product photos here :(

Image

Also, please make Cart page styled with min-height: 100vh

Image

Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. change favicon and title
Image
  1. user should have ability to open ProductDetailPage from Cart
Image
  1. fix linter errors/warnings

Comment on lines +118 to +128
onClick={() => {
const confirmed = window.confirm(
'Checkout is not implemented yet. ' +
'Do you want to clear the Cart?',
);

if (confirmed) {
clearCart();
}
}}
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to separate fn

@lkovbasiuk lkovbasiuk requested a review from 2pasha March 5, 2026 13:16
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants