Skip to content

Develop#911

Open
Vitaligna wants to merge 6 commits intomate-academy:masterfrom
Vitaligna:develop
Open

Develop#911
Vitaligna wants to merge 6 commits intomate-academy:masterfrom
Vitaligna:develop

Conversation

@Vitaligna
Copy link

Copy link

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

A few things to improve:

  1. Minor fix here. When I try to search by text series 5 I can't write space between series and 5
Image
  1. Products are supposed to display on the left side according to design
Image Image
  1. Colors here are equal (first and last)
Image Image
  1. On tablet the left border goes outside the navigation buttons container
Image

One recommendation

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. there is still a problem with the colours
Image
  1. disable page scrolling when the menu is open
Image
  1. it would be great if you could add a hover effect to the product cards
Image
  1. add the option to delete a product from the cart by pressing the button again
Image

@Vitaligna Vitaligna requested a review from etojeDenys March 2, 2026 08:54
Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s check this:

  1. I add items to the cart and when I click on it there is no search option, so why does the magnifying glass icon disappear when I have 20+ items?
    It is worth adding such an opportunity there as well:
Image
  1. When I select something in this section, the page should scroll smooth to the top:
Image
  1. Add the. underline hover effect to this links, and each of them should redirect to existing resources:
Image

@Vitaligna Vitaligna requested a review from brespect March 2, 2026 13:35
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job you did!

One tiny fix and your PR will be approved:

  1. Check out styles in the Footer navbar:
Image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants