Open
Conversation
Feat/app layout routing
feat: implement data layer with typed api client
feat: add product card and products list
feat: implement sorting and pagination
feat: implement basic product details page
This reverts commit beb0048.
Feat/product details
fix: improve back button navigation logic
Feat/product details phase 3
Feat/homepage
Feat/products controls
Feat/products search
Feat/homepage UI
etojeDenys
suggested changes
Mar 3, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
good job
- products in this section should not be discounted
- photos should not be cropped
- make sure that this section looks the same as the layout
layout:
- place the buttons on the same lines
- add a favicon and a title
fix: mentor review comments
brespect
suggested changes
Mar 5, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, almost done, check this:
-
After select item in this section the page should smoothly scrolls to the top:
. -
Use logo as favicon.
-
All of these links in the footer should be real links to relevant existing resources:
Denys-Kravchuk9988
suggested changes
Mar 5, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
I would recommend to align the images' height to fit height of side buttons and remove the space below these buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed React Phone Catalog app
DEMO
https://prokesha.github.io/react_phone-catalog/