Skip to content

Develop#916

Open
iirk1 wants to merge 8 commits intomate-academy:masterfrom
iirk1:develop
Open

Develop#916
iirk1 wants to merge 8 commits intomate-academy:masterfrom
iirk1:develop

Conversation

@iirk1
Copy link

@iirk1 iirk1 commented Mar 3, 2026

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s check next:

  1. Add some padding to give the user the ability to select this sections, not only by clicking directy on the icons:
Image
  1. Add favicon and change title in the browser tab.
  2. When I select something in pagination it jumps me to the top of page:
Image
  1. All this links should lead to correct resourses:
Image
  1. Lets add correct icon for this button, not just "^" symbol:
Image
  1. When I select something here it should scroll me smooth to the top:
Image

Also, don`t forget to pass all tests and linter staged, before requesting the mentor's review 😉

@iirk1
Copy link
Author

iirk1 commented Mar 4, 2026

  1. When I select something in pagination it jumps me to the top of page:
    I think it`s a good approach because when you click on another page, you should see the top of the new page with new products.

About the linter and test, Mentor said its not necessary to pass the test because its only a single test, and I wrote the hidden title, but I dont understand why it doesnt pass. Also, for the linter, I don`t know how to fix the problem with the selector :global.

@iirk1 iirk1 requested a review from brespect March 4, 2026 16:44
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. it would be better if the whole square were a link
Image
  1. add the option to remove the product by pressing the button again
Image
  1. after changing the 'item on page', the page number should be set to 1
Image
  1. make sure you don't forget to increase these numbers as well
Image

@iirk1 iirk1 requested a review from etojeDenys March 5, 2026 15:43
Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants