Open
Conversation
brespect
suggested changes
Mar 4, 2026
There was a problem hiding this comment.
Good progress, let`s check next:
- Add some padding to give the user the ability to select this sections, not only by clicking directy on the icons:
- Add favicon and change title in the browser tab.
- When I select something in pagination it jumps me to the top of page:
- All this links should lead to correct resourses:
- Lets add correct icon for this button, not just "^" symbol:
- When I select something here it should scroll me smooth to the top:
Also, don`t forget to pass all tests and linter staged, before requesting the mentor's review 😉
Author
About the linter and test, Mentor said it |
etojeDenys
suggested changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




https://iirk1.github.io/react_phone-catalog/