Conversation
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
almost done
after pressing 'toggle all', the loader should only appear on todos that will change status. In your solution, it appears on every todo
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
It seems that previous comment wasn't fixed. The loading state for all todos (completed/uncompleted) is still reproducable. Please check if last changes were deployed.
src/components/TodoItem/TodoItem.tsx
Outdated
| value={newTitle} | ||
| onChange={e => setNewTitle(e.target.value)} | ||
| onBlur={() => handleUpdateTodo(todo.id, newTitle)} | ||
| onKeyDown={e => { |
There was a problem hiding this comment.
I would recommend to extract this code into a separate callback
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Please resolve an issue from last mentor' review:
No changes from last review
Подивіться, будь ласка, коміт added callback and deployed the app. Я просто закомітила до останнього рев"ю і не запушила випадково, а запушила вже після рев"ю |
@ValentynaITCh
має пройти новий коміт та підтягнутись зміни |
4 participants
https://ValentynaITCh.github.io/react_todo-app-with-api/