Skip to content

Develop#2134

Open
rekverr wants to merge 4 commits intomate-academy:masterfrom
rekverr:develop
Open

Develop#2134
rekverr wants to merge 4 commits intomate-academy:masterfrom
rekverr:develop

Conversation

@rekverr
Copy link

@rekverr rekverr commented Mar 1, 2026

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but for now I cannot select the complete todo checkmark:
Image

@rekverr rekverr requested a review from brespect March 2, 2026 15:40
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Check out comment below - it should be helpful

export const App: React.FC = () => {
const [filter, setFilter] = useState<FilterType>(FilterType.ALL);
const [newTodoTitle, setNewTodoTitle] = useState('');
const { errorMessage, setErrorMessage } = useErrorMessage();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making a custom type / enum for error states (e.g. ErrorMessage) and re-use it to avoid hard-coded typos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants