Open
Conversation
Anton-Kuchmasov
suggested changes
Mar 2, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Good job!
Check out comments below - they might be helpful
src/App.tsx
Outdated
| getTodos() | ||
| .then(setTodos) | ||
| .catch(() => { | ||
| setErrorMessage('Unable to load todos'); |
There was a problem hiding this comment.
Please create a custom type / enum (e.g. ErrorMessage), put inside all possible Error Messages and re-use it to avoid hard-coded errors
src/App.tsx
Outdated
| }); | ||
| }, []); | ||
|
|
||
| // Auto-focus input after add/delete operations |
src/App.tsx
Outdated
Comment on lines
+56
to
+58
| const handleCloseError = useCallback(() => { | ||
| setErrorMessage(''); | ||
| }, []); |
There was a problem hiding this comment.
what's purpose of this function, especially - of wrapping it inside useCallback() ?
Author
|
edited code according reccomendations DEMO LINK |
2pasha
suggested changes
Mar 3, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job!
please make sure that you have passed all tests before submitting
src/components/Footer.tsx
Outdated
| className={cn('filter__link', { | ||
| selected: filter === value, | ||
| })} | ||
| data-cy={`FilterLink${value}`} |
Author
|
edited code DEMO LINK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done "React Todo App with API" task
DEMO LINK