Open
Conversation
2pasha
suggested changes
Mar 7, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements below ⬇️
src/components/Footer.tsx
Outdated
Comment on lines
+26
to
+53
| <a | ||
| href="#/" | ||
| className={classNames('filter__link', { selected: filter === 'all' })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter('all')} | ||
| > | ||
| All | ||
| </a> | ||
| <a | ||
| href="#/active" | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'active', | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter('active')} | ||
| > | ||
| Active | ||
| </a> | ||
| <a | ||
| href="#/completed" | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'completed', | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter('completed')} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you may create separate enum with filter values and map through it
src/components/Footer.tsx
Outdated
Comment on lines
+6
to
+7
| filter: 'all' | 'active' | 'completed'; | ||
| setFilter: (filter: 'all' | 'active' | 'completed') => void; |
src/components/TodoItem.tsx
Outdated
Comment on lines
+87
to
+96
| onKeyUp={e => { | ||
| if (e.key === 'Enter') { | ||
| handleSubmit(); | ||
| } | ||
|
|
||
| if (e.key === 'Escape') { | ||
| setNewTitle(todo.title); | ||
| onEdit(null); | ||
| } | ||
| }} |
src/App.tsx
Outdated
|
|
||
| newTodoRef.current?.focus(); | ||
| } catch { | ||
| setError('Unable to delete a todo'); |
There was a problem hiding this comment.
in future, when you will have more that one error message, it's better to move your messages into separate enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://VitaliyHoroshko.github.io/react_todo-app-with-api/