Open
Conversation
ProKesha
commented
Feb 18, 2026
ProKesha
commented
- DEMO LINK
brespect
suggested changes
Feb 18, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, let`s check next:
- There should be an error when I try to submit empty todo.
- There should be the loader on deleting on every todo.
- Fix the input focus on UI.
2pasha
suggested changes
Feb 19, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- fix your input
- fix your error message
- fix your styles for hidden notification
Comment on lines
+18
to
+40
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === FilterStatus.All ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === FilterStatus.Active ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === FilterStatus.Completed ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you may create enum for your filters and map through it
etojeDenys
suggested changes
Feb 19, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
it seems that you forgot to deploy the changes because the problems from the previous review have not been resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.