-
Notifications
You must be signed in to change notification settings - Fork 922
Update rVV10 parameters for r2SCAN+rVV10 in MPScanRelaxSet() #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update rVV10 parameters for r2SCAN+rVV10 in MPScanRelaxSet() #4504
Conversation
-Add the code to update rVV10 parameters ("BPARAM"=11.95) for r2SCAN+rVV10 if vdw is set to "rvv10" and METAGGA is "R2SCAN"
|
Hey @junchichen21 can you take a look at how this is already done in MP24RelaxSet and perhaps merge the incar updates into a common function for both the older |
|
Also, unittests are needed. Thanks. |
Hi @esoteric-ephemera, I somehow missed your message last week. Sorry about that. No problem, I will update it soon. |
…Set for the given XC functional and dispersion correction
…eters; streamline vdw handling with _config_updates function.
…ling with _config_updates function
…correction validation
…n version compatibility
…ove dispersion handling
|
Hi @esoteric-ephemera and @shyuep, I have made some updates as shown below: Refactoring and code unification:
API and interface changes:
Validation and error handling improvements:
Test updates and additions:
Please let me know whether the above refactoring and interface changes align with the intended update policy. |
|
Looks ok to me. @esoteric-ephemera To review. |
This pull request updates the
MPScanRelaxSetclass insrc/pymatgen/io/vasp/sets.pyto improve support for the r2SCAN+rVV10 functional. It adds a new reference for r2SCAN+rVV10 and ensures that the appropriateBPARAMvalue is set in the INCAR when using this functional.Functional and documentation enhancements:
__post_init__method to automatically setBPARAM = 11.95in the INCAR whenvdwis set to"rvv10"andMETAGGAis"R2SCAN". If the user specifiesuser_incar_settings={"METAGGA": "SCAN"}, thenBPARAMkeeps the same value as defined in thevdW_parameters.yamlfile.