-
Notifications
You must be signed in to change notification settings - Fork 63
Generalize integration_by_parts #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Generalize integration_by_parts #1674
Conversation
|
Are not all 4 versions the same, the only difference being whether the minus is inside or outside the integral? |
If you said that these lemmas can be proved with one of them, I think it is no. |
949b179 to
0802b9c
Compare
Indeed |
To give a bit of context, these lemmas have been written this way after having been tested to formalize the Gamma function. Maybe their apparent specialization is the result of practical considerations? @IshiguroYoshihiro can you confirm? (Or am I remembering wrong?) |
Tragicus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am back.
One way to factorize would be to ask for the relevant functions to have constant sign. I was also wondering whether we want to generalize over the interval, instead of [a, +oo[. We would require that the relevant functions are derivable on the interior of the interval and have limits at the boundaries.
@affeldt-aist Some of the following suggestions are quite ugly but save a lot of time, what do you think?
theories/ftc.v
Outdated
| rewrite (@integration_by_partsy_le0_ge0 R (- F)%R G (- f)%R g a (- FGoo))//. | ||
| - rewrite oppeD; last exact: fin_num_adde_defr. | ||
| rewrite -EFinN opprD 2!opprK mulNr. | ||
| by under eq_integral do rewrite mulNr EFinN oppeK. | ||
| - by move=> ?; apply: cvgN; exact: cf. | ||
| - exact: derivable_oy_continuous_bndN. | ||
| - by move=> ? ?; rewrite fctE derive1N ?Ff//; move: Foy => [+ _]; apply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| rewrite (@integration_by_partsy_le0_ge0 R (- F)%R G (- f)%R g a (- FGoo))//. | |
| - rewrite oppeD; last exact: fin_num_adde_defr. | |
| rewrite -EFinN opprD 2!opprK mulNr. | |
| by under eq_integral do rewrite mulNr EFinN oppeK. | |
| - by move=> ?; apply: cvgN; exact: cf. | |
| - exact: derivable_oy_continuous_bndN. | |
| - by move=> ? ?; rewrite fctE derive1N ?Ff//; move: Foy => [+ _]; apply. | |
| rewrite (@integration_by_partsy_le0_ge0 R (- F)%R G (- f)%R g a (- FGoo))//. | |
| - rewrite oppeD; last exact: fin_num_adde_defr. | |
| rewrite -EFinN opprD 2!opprK mulNr. | |
| by under eq_integral do rewrite mulNr EFinN oppeK. | |
| - by move=> ?; apply: cvgN; exact: cf. | |
| - exact: derivable_oy_continuous_bndN. | |
| - by move=> ? ?; rewrite fctE derive1N ?Ff => [//|//|]; apply: Foy.1. |
.6s faster
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
Co-authored-by: Quentin VERMANDE <[email protected]>
FYI, here is the PR that formalizes the Gamma function:
This has not been tested yet (by lack of time). :-(
We have merged all of them. Thanks for identifying the performance issues, that helps. |
Motivation for this change
Add a part of generalized version of integration by parts for unbound intervals
`[a, +oo[.This PR is over #1656 and #1662.
I don't sure that I should add 4 more lemmas and complete all variation of integration by parts for unbound intervals.
I think that 8 similar lemmas would be a mess. So, I'd like to somehow make them up into one or two lemmas, but I don't have an idea.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers