Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify comments for python related functions #440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markelog
Copy link

No description provided.

.functions Outdated
@@ -95,6 +95,7 @@ function gitio() {
}

# Start an HTTP server from a directory, optionally specifying the port
# (Requires python)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markelog Requires Python 2 (see: #384).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you

dndhm pushed a commit to dndhm/dotfiles that referenced this pull request Nov 26, 2017
In mathiasbynens#440, a `move_to_front_of_path` function was introduced, but
was [ultimately not used][1] when these changes were merged as f7c73f7.
The function itself was not removed, however.

This commit removes the unused function.

[1]: thoughtbot/dotfiles#440 (comment)
@mathiasbynens mathiasbynens changed the base branch from master to main June 16, 2020 07:07
minhptx pushed a commit to minhptx/dotfiles that referenced this pull request Apr 13, 2021
In mathiasbynens#440, a `move_to_front_of_path` function was introduced, but
was [ultimately not used][1] when these changes were merged as f7c73f7.
The function itself was not removed, however.

This commit removes the unused function.

[1]: thoughtbot/dotfiles#440 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants