Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Aug 29, 2025

This PR uses node to call components/bin/makeAll in the package.json scripts rather than assuming the file is executable.

@dpvc dpvc requested a review from zorkow August 29, 2025 11:39
@dpvc dpvc added this to the v4.0.1 milestone Aug 29, 2025
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (afaf1ea) to head (8f74777).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1339   +/-   ##
========================================
  Coverage    86.72%   86.72%           
========================================
  Files          337      337           
  Lines        84145    84145           
  Branches      3140     3140           
========================================
  Hits         72971    72971           
  Misses       11174    11174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 2a531d2 into develop Oct 10, 2025
3 checks passed
@dpvc dpvc deleted the fix/makeAll branch October 10, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants