Improve HTTP Client structure

app/Notification/AppNotificationInterface.php

@@ -4,12 +4,12 @@
 namespace App\Notification;
 
 
-use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HttpClientAdapterInterface;
+use Psr\Http\Message\ResponseInterface;
 
 interface AppNotificationInterface
 {
-    public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType);
+    public function __construct(HttpClientAdapterInterface $client, string $message, string $messageType);
 
-    public function notify(): ResponseAdapterInterface;
+    public function notify(): ResponseInterface;
 }

app/Notification/Client/Guzzle/GuzzleHttpClient.php

@@ -0,0 +1,29 @@
+<?php
+
+
+namespace App\Notification\Client\Guzzle;
+
+
+use App\Notification\Client\HttpClientAdapterInterface;
+use GuzzleHttp\Client;
+use Psr\Http\Message\ResponseInterface;
+
+final class GuzzleHttpClient implements HttpClientAdapterInterface
+{
+    private Client $client;
+
+    public function __construct()
+    {
+        $this->client = new Client();
+    }
+
+    public function post(string $url, array $params): ResponseInterface
+    {
+        return $this->client->post(
+            $url,
+            [
+                'json' => $params
+            ]
+        );
+    }
+}

app/Notification/Client/HttpClientAdapterInterface.php

@@ -0,0 +1,12 @@
+<?php
+
+
+namespace App\Notification\Client;
+
+
+use Psr\Http\Message\ResponseInterface;
+
+interface HttpClientAdapterInterface
+{
+    public function post(string $url, array $params): ResponseInterface;
+}

app/Notification/Slack/SlackNotification.php

@@ -5,21 +5,21 @@
 
 
 use App\Notification\AppNotificationInterface;
-use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HttpClientAdapterInterface;
+use Psr\Http\Message\ResponseInterface;
 
 final class SlackNotification implements AppNotificationInterface
 {
     private SlackStylizedMessageCreator $message;
-    private HTTPClientAdapterInterface $client;
+    private HttpClientAdapterInterface $client;
 
-    public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType)
+    public function __construct(HttpClientAdapterInterface $client, string $message, string $messageType)
     {
         $this->message = new SlackStylizedMessageCreator($message, $messageType);
         $this->client  = $client;
     }
 
-    public function notify(): ResponseAdapterInterface
+    public function notify(): ResponseInterface
     {
         return $this->client->post(
             getenv('SLACK_API_WEBHOOK'),

app/Route/Router.php

@@ -4,7 +4,7 @@
 namespace App\Route;
 
 
-use App\Notification\Client\Guzzle\GuzzleHTTPClient;
+use App\Notification\Client\Guzzle\GuzzleHttpClient;
 use App\Notification\NotificationTypeEnum;
 use App\Notification\StatusCodeEnum;
 use App\Notification\Slack\SlackNotification;
@@ -41,7 +41,7 @@ private static function createReflectionMethod(array $uriContent): ReflectionMet
             return new ReflectionMethod($uriContent['namespace'], $uriContent['method']);
         } catch (ReflectionException $exception) {
             (new SlackNotification(
-                new GuzzleHTTPClient(),
+                new GuzzleHttpClient(),
                 $exception->getMessage(),
                 NotificationTypeEnum::ERROR()
             ))->notify();

composer.json

@@ -41,6 +41,6 @@
         "phpunit/phpunit": "8.5.*"
     },
     "scripts": {
-        "tests": "./vendor/bin/phpunit tests --color=always --stop-on-failure",
+        "tests": "./vendor/bin/phpunit tests --color=always --stop-on-failure"
     }
 }

tests/Notification/Fake/FakeHttpClient.php

@@ -0,0 +1,23 @@
+<?php
+
+
+namespace App\Test\Notification\Fake;
+
+
+use App\Notification\Client\HttpClientAdapterInterface;
+use Psr\Http\Message\ResponseInterface;
+
+class FakeHttpClient implements HttpClientAdapterInterface
+{
+    private ResponseInterface $response;
+
+    public function mockResponse(ResponseInterface $response): void
+    {
+        $this->response = $response;
+    }
+
+    public function post(string $url, array $params): ResponseInterface
+    {
+       return $this->response;
+    }
+}

tests/Notification/FakeNotificationResponseTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace App\Test\Notification\Slack;
+
+use App\Test\Notification\Fake\FakeHttpClient;
+use GuzzleHttp\Psr7\Response;
+use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\TestCase;
+
+class FakeNotificationResponseTest extends TestCase
+{
+    public static function test_FakeHttpClient_ShouldAssertHttpResponse(): void
+    {
+        $notificationResponse = new Response(
+            $statusCode = 200,
+            $responseHeader = [],
+            $responseBody = null,
+            $protocolVersion = '1.1',
+            $responseReason = 'OK'
+        );
+
+        $fakeClient = new FakeHttpClient();
+        $fakeClient->mockResponse($notificationResponse);
+
+        $response = $fakeClient->post($fakeUrl = 'https://fake.com', $emptyParams = []);
+
+        Assert::assertEquals($expectedStatusCodeResponse = 200, $response->getStatusCode());
+        Assert::assertEquals($expectedPhraseResponse = 'OK', $response->getReasonPhrase());
+    }
+}