Remove the unminified Vue UMD bundle - #463
Merged
Merged
Conversation
Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified LoginLdap.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027.
sgiehl
added a commit
that referenced
this pull request
Aug 9, 2026
Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified LoginLdap.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027.
sgiehl
added a commit
that referenced
this pull request
Aug 10, 2026
* Prepare for Matomo 6 Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1. * Run tests on same PHP versions as core (8.1, 8.5) * Rebuild Vue dist files with the Vite build for Matomo 6 & fix ESLint violations (#439) * Rebuild Vue dist files with the Vite build for Matomo 6 * Rebuild Vue dist files for Vue 3.5 * Export LoginLdap state interfaces for declaration emit (TS4082) * Run plugin tests against MySQL 8.0 and MariaDB 10.6 (#444) * Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg. * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) (#447) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16. * Drop registration of removed core variables.less (#454) Core PR "Prune dead and deprecated LESS variables" (matomo-org/matomo#24925) deletes plugins/Login/stylesheets/variables.less. Registering a file that no longer exists makes stylesheet merging throw "The ui asset with 'href' = ... is not readable", which broke every view- or email-rendering test of this plugin. Nothing here used @login-section-background, so the line can simply go. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * Update UI screenshots (#451) Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397. * Remove the unminified Vue UMD bundle (#463) Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified LoginLdap.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027. * Use the matomo6_* PHP version aliases in the test workflow [ignore_release] * Raise PHPStan phpVersion to 8.1 and prune stale excludePaths [ignore_release] * Add changelog entry for Matomo 6 compatibility [ignore_release] * Replace assertRegExp with assertMatchesRegularExpression for PHPUnit 9 [ignore_release] * Rebuild Vue dist after restacking on 6.x-dev [ignore_release] * Correct the LDAP connection property type for PHP 8.1 [ignore_release] * Update admin page screenshot for Matomo 6 and the restacked 5.x changes [ignore_release] --------- Co-authored-by: Thomas ZILLIOX <thomas@zilliox.me> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unminified
<Plugin>.umd.jsVue bundle, which is no longer built, and adds a.gitignoreentry so it does not come back.Matomo's Vue build used to run two full Vite passes per plugin, emitting an unminified
<Plugin>.umd.jsnext to<Plugin>.umd.min.js. Only the minified bundle is ever served:PluginUmdAssetFetcher::getUmdFileToUseForPlugin()andgetAllPluginUmds()look exclusively for.umd.min.js..development.umd.js, produced byvue:build --watchand already gitignored.The unminified pass was a leftover from Vue CLI, whose
--target libbuild emitted.common.js,.umd.jsand.umd.min.jsin one go..common.jswas gitignored away long ago;.umd.jssurvived only because it came for free.Core change: matomo-org/matomo#25027. Once that lands, this file is no longer regenerated by
vue:build.Notes for review
.umd.js, and.umd.min.jsis untouched, so this is safe to merge before or after the core PR..gitignorepattern*.umd.jsdoes not match*.umd.min.js.Checklist