Conversation
Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1.
…violations (#439) * Rebuild Vue dist files with the Vite build for Matomo 6 * Rebuild Vue dist files for Vue 3.5 * Export LoginLdap state interfaces for declaration emit (TS4082)
* Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
… Puppeteer 24) (#447) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16.
Core PR "Prune dead and deprecated LESS variables" (matomo-org/matomo#24925) deletes plugins/Login/stylesheets/variables.less. Registering a file that no longer exists makes stylesheet merging throw "The ui asset with 'href' = ... is not readable", which broke every view- or email-rendering test of this plugin. Nothing here used @login-section-background, so the line can simply go. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397.
Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified LoginLdap.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027.
…9 [ignore_release]
…es [ignore_release]
AltamashShaikh
approved these changes
Aug 10, 2026
AltamashShaikh
requested changes
Aug 10, 2026
AltamashShaikh
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares LoginLdap for Matomo 6.
This branch existed before
6.x-devdid, so it has been restacked:6.x-devwas created in parity with5.x-dev, and the eight existing preparation commits were rebased onto it. The branch now carries the 285.x-devcommits it previously missed — including the password hash logic change (#AS-649), synchronising LDAP users by the resolved Matomo login (#AS-633) and the password-confirmation default (#PG-5346).On top of the restack:
plugin.json—6.0.0, requiring>=6.0.0-b1,<7.0.0-b1. The-b1lower bound matters: a plain>=6.0.0sorts above6.0.0-b1and would disable the plugin against a beta core.upload-artifactscondition now use thematomo6_min_php/matomo6_max_phpaliases instead of pinned literals, so they track core rather than drifting. The generator comment in the header was updated to match.phpstan.neon—phpVersionraised to80100, and theexcludePathspruned. PHPStan 2 (bundled with Matomo 6) fails hard on anexcludePathsentry that matches nothing, so on the previous config it refused to run at all. The absentvendor/entry was dropped andgithub-action-tests/marked optional with(?)— it does not exist in the repo butcheckout_matomo.shcreates it during a CI run.CHANGELOG.md— a6.0.0entry, following the undated shape this repository used for the5.0.0major-preparation entry.assertRegExp()→assertMatchesRegularExpression().Ldap\Client::$connectionResource— docblock corrected to\LDAP\Connection|false|null. PHP 8.1 changedldap_connect()from returning aresourceto anLDAP\Connectionobject; the stale@var resourceproduced nine false PHPStan errors oncephpVersionwas raised.vue/dist— rebuilt from the restacked sources, so the minified bundle matches the mergedvue/src.Notes for review
ControllerextendsLogin\Controller, which has no#[JsonResponse]actions, so the new controller contract does not apply here.5.x-devseparately.vue:buildclean,plugin:activatesucceeds,core:updatereports no pending migrations. The integration suite was not run locally — it needs a runningslapd, whichsetup_ldap.shprovides in CI.[ignore_release]: none of this changes plugin behaviour, and nothing can be released for Matomo 6 until core ships.prepare6xas their base and were rebased under; their diffs will have recomputed.Checklist