Conversation
The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0.
sgiehl
marked this pull request as ready for review
July 20, 2026 09:05
PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
sgiehl
added a commit
that referenced
this pull request
Aug 9, 2026
* Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
sgiehl
added a commit
that referenced
this pull request
Aug 10, 2026
* Prepare for Matomo 6 Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1. * Use Db\Schema for table optimization Matomo 6 removes the deprecated Db::optimizeTables() and Db::isOptimizeInnoDBSupported() wrappers; call the Schema instance directly instead. * Run tests on same PHP versions as core (8.1, 8.5) * Run plugin tests against MySQL 8.0 and MariaDB 10.6 (#326) * Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg. * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) (#327) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Stabilise queue-enabled toggle click under the new headless Chrome Scroll the toggle to the viewport centre before clicking; under Chrome 149 it could otherwise be reported as 'not clickable' when behind a sticky header. * Use a JS click for the queue-enabled toggle under modern headless Chrome page.click() reports the Materialize lever as not clickable on the new Chrome even after scrolling it into view; dispatching the click directly fires the toggle handler reliably. * Wait for the password-confirmation modal before interacting with it After enabling the queue toggle the submit opens a password-confirmation modal; under the modern headless Chrome its input is not focusable and its confirm button not clickable until the open animation finishes. Wait for them to be visible and use a JS click for the confirm button. * Use a JS click for the settings submit button page/element click can be reported as not clickable under the modern headless Chrome, so the password-confirmation modal never opened; dispatch the click directly to trigger it reliably. * Fix the queue-enabled error test for the modern headless Chrome Three Chrome-149 issues stacked in this test: the queue toggle was clicked via its label span (which no longer reliably flips the checkbox), so the setting never changed; and the password-confirmation modal selectors were unscoped, so they matched a closed .confirm-password-modal instance instead of the open one. Click the checkbox input directly, JS-click the submit button, and scope all modal interactions to .modal.open. Verified locally: the redis connection error is now shown as expected. * Update settings_save_error expected screenshot for Chrome 149 * Shorten UI-test comments added during the Puppeteer 24 migration * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16. * Update UI screenshots (#329) Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397. * Add changelog entry for Matomo 6 compatibility [ignore_release] * Use the matomo6 PHP version aliases in the test workflow [ignore_release] --------- Co-authored-by: Thomas ZILLIOX <thomas.zilliox@innocraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the plugin test workflow to run against the new minimum supported database versions. It previously inherited the shared
github-action-testsMySQL 5.7 default, which is below Matomo's new minimum (MySQL 8.0 / MariaDB 10.6).Core PR: matomo-org/matomo#24858
Checklist