Skip to content

Conversation

pcworld
Copy link

@pcworld pcworld commented Jul 13, 2025

set -x shows the command in the output, making the output's respective command clearer. Using ; rather than && also runs the other commands even if one fails, for example if "jupyter-nbextension" is not found.

set -x shows the command in the output, making the output's respective command clearer.
Using `;` rather than `&&` also runs the other commands even if one fails, for example if "jupyter-nbextension" is not found.
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pcworld/ipympl/patch-1

Copy link
Collaborator

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR! Unfortunately on my terminal (zsh) it broke some things so we need to find a way to deal with that

@@ -17,7 +17,7 @@ In general, please make sure you are using the latest versions of software when
Please include the result of the following command, which will print out the version of python, ipympl and the Jupyter ecosystem.

```bash
python -c "import sys; print('\n',sys.version); import ipympl; print('ipympl version:', ipympl.__version__)" && jupyter --version && jupyter nbextension list && jupyter labextension list
set -x ; python -c "import sys; print('\n',sys.version); import ipympl; print('ipympl version:', ipympl.__version__)" ; jupyter --version ; jupyter nbextension list ; jupyter labextension list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This set -x seems to dramatically break the output for me on zsh

we need this command to be as shell agnostic as possible.

An alternative is to have a "print_debug_info" in ipympl so we could have python -c "import ipympl; ipympl.print_debug_info()

At minimum we need to remove set -x or find a more general way to get the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants