Skip to content

Decreased minimum mav value from 2 to 1 #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Decreased minimum mav value from 2 to 1 #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mplfinance/_arg_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ def _valid_mav(value, is_period=True):
if not isinstance(value,(tuple,list,int)):
return False
if isinstance(value,int):
return (value >= 2 or not is_period)
return (value >= 1 or not is_period)
# Must be a tuple or list here:
for num in value:
if not isinstance(num,int) or (is_period and num < 2):
if not isinstance(num,int) or (is_period and num < 1):
return False
return True

Expand Down