Skip to content

Implement MSC3898: Native Matrix VoIP signalling for cascaded SFUs #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 163 commits into from
Closed

Implement MSC3898: Native Matrix VoIP signalling for cascaded SFUs #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
163 commits
Select commit Hold shift + click to select a range
705688d
untested WIP for calling SFUs
ara4n May 31, 2022
36eeb27
fix types
ara4n May 31, 2022
0958b45
fix lint
ara4n May 31, 2022
42e78e0
Merge branch 'dbkr/group-call-merge' into matthew/sfu
ara4n Jun 3, 2022
bc3d326
defloatify settings
ara4n Jun 4, 2022
cab5a70
fix lint
ara4n Jun 4, 2022
fb671cf
switch SFU config to matrixClient opts
ara4n Jun 4, 2022
b200725
fix configurable call encryption
ara4n Jun 5, 2022
f566f39
hook up SDP nego over DC
ara4n Jun 5, 2022
e3e1633
better DC TIDs
ara4n Jun 5, 2022
a9e6b75
publish IDs from PC; ditch stream_id
ara4n Jun 5, 2022
fe93ba8
publish feeds correctly
ara4n Jun 5, 2022
37aea42
scrape track IDs from SDP :/
ara4n Jun 6, 2022
baacedf
get signalling over DC working
ara4n Jun 6, 2022
4e1346c
don't barf on SFU having no room member
ara4n Jun 6, 2022
43a6919
fix logging
ara4n Jun 6, 2022
67c7957
lint
ara4n Jun 6, 2022
ba58897
uncommited comments
ara4n Jul 12, 2022
e22aaac
Merge branch 'robertlong/group-call' into matthew/sfu
SimonBrandner Jul 30, 2022
e6576ce
Add useful logging and comments
SimonBrandner Jul 30, 2022
f7ec3ab
Choose opponent more correctly
SimonBrandner Jul 30, 2022
89c9695
Disable E2E when we are using an SFU
SimonBrandner Jul 30, 2022
164e0a4
Don't warn about missing `SDPStreamMetadata` on SFU calls
SimonBrandner Jul 30, 2022
889030b
Make basic group calling work
SimonBrandner Jul 31, 2022
b3177d5
Add `disposed` prop
SimonBrandner Aug 2, 2022
572c854
Remove `disposed` feeds
SimonBrandner Aug 2, 2022
05be466
Reformat
SimonBrandner Aug 2, 2022
854736a
Clear `subscribedStreams` when ending call
SimonBrandner Aug 2, 2022
7fca561
A **very** ugly hack to make leaving work
SimonBrandner Aug 2, 2022
3e8bce5
Merge remote-tracking branch 'upstream/robertlong/group-call' into ma…
SimonBrandner Aug 2, 2022
3c2eb17
Create a call with the SFU right when entering the conference
SimonBrandner Aug 3, 2022
b965343
Reduce diff
SimonBrandner Aug 3, 2022
ca7532e
More diff reduction
SimonBrandner Aug 3, 2022
9f7672c
Remove a no-longer necessary hack
SimonBrandner Aug 3, 2022
1190bd0
Remove unused prop
SimonBrandner Aug 3, 2022
1069bdc
Introduce `getSFU()`
SimonBrandner Aug 3, 2022
02b6782
Move `subscribeToSFU()` to `MatrixCall`
SimonBrandner Aug 3, 2022
cd2bcaf
Remove stale comment
SimonBrandner Aug 3, 2022
fcef2bd
Reduce diff
SimonBrandner Aug 3, 2022
2f8207f
Naming fix
SimonBrandner Aug 3, 2022
a884fec
Further reduce diff
SimonBrandner Aug 3, 2022
3805783
Extract `sendSFUDataChannelMessage()`
SimonBrandner Aug 3, 2022
1db93c3
Select by both `streamId` and `trackId`
SimonBrandner Aug 3, 2022
024bab9
Remove unused interface
SimonBrandner Aug 3, 2022
de26e64
Fix unused import
SimonBrandner Aug 3, 2022
ca26e66
Make sure to not `undefined` tracks
SimonBrandner Aug 4, 2022
785db35
Simplify what we're sending in member state
SimonBrandner Aug 4, 2022
31d3ba3
Reduce diff
SimonBrandner Aug 4, 2022
24c7f09
Use `transceivers` instead of `senders`
SimonBrandner Aug 6, 2022
be5d857
`newCall` -> `sfuCall`
SimonBrandner Aug 6, 2022
205920e
Add `getGroupCallRoomMemberFeeds()`
SimonBrandner Aug 6, 2022
cca9eda
Call `sendMemberStateEvent()` more intelligently
SimonBrandner Aug 6, 2022
98156e0
Add screen-sharing support
SimonBrandner Aug 6, 2022
2dc7581
Handle `ISfuInfo` better
SimonBrandner Aug 6, 2022
4d901bf
Make mute signalling work
SimonBrandner Aug 6, 2022
e98ec6d
Update comment
SimonBrandner Aug 8, 2022
836db69
Fix possible race condition
SimonBrandner Aug 9, 2022
17f4140
Avoid race condition where we would call people full-mesh
SimonBrandner Aug 9, 2022
ec7a6a2
Try to get the `trackId`s from SDP
SimonBrandner Aug 9, 2022
05e92e0
Don't be an idiot, Simon
SimonBrandner Aug 9, 2022
1b616bf
Be safe
SimonBrandner Aug 9, 2022
ccd55b2
Add some logging
SimonBrandner Aug 9, 2022
ba6f4e0
Hack to send state events when local description changes
SimonBrandner Aug 9, 2022
1e58c19
More logging
SimonBrandner Aug 9, 2022
f0fd240
Event more logging
SimonBrandner Aug 9, 2022
892201f
Smarter logging
SimonBrandner Aug 9, 2022
55111b6
Even more logging
SimonBrandner Aug 9, 2022
bf8bfba
Types?
SimonBrandner Aug 9, 2022
1537a2b
Tidy up code
SimonBrandner Aug 9, 2022
95051ab
Implement SFU timeouts
SimonBrandner Aug 11, 2022
dba90c7
Fix timeouts
SimonBrandner Aug 11, 2022
fae7bb4
Don't spam SFUs with metadata
SimonBrandner Aug 12, 2022
e2dc5d3
Merge branch 'robertlong/group-call' into matthew/sfu
SimonBrandner Aug 12, 2022
cfa11e2
Delint
SimonBrandner Aug 12, 2022
9012b28
Don't publish tracks that are not in SDP
SimonBrandner Aug 12, 2022
b361f8d
Properly skip track-less
SimonBrandner Aug 12, 2022
5159b24
Switch to data-channel for sending metadata
SimonBrandner Aug 13, 2022
b837da2
Remove unused field
SimonBrandner Aug 13, 2022
456a88a
Merge remote-tracking branch 'upstream/robertlong/group-call' into ma…
SimonBrandner Aug 20, 2022
2d95d22
Remove TODO we decided not to do
SimonBrandner Aug 20, 2022
09b42bf
Merge remote-tracking branch 'upstream/robertlong/group-call' into ma…
SimonBrandner Aug 30, 2022
1b2c1f9
Merge branch 'robertlong/group-call' into matthew/sfu
SimonBrandner Nov 8, 2022
bfdb974
Fixup
SimonBrandner Nov 8, 2022
6bef812
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Nov 8, 2022
f982558
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Nov 9, 2022
c931953
Improve TS
SimonBrandner Nov 12, 2022
3e4fcd9
Improve TS
SimonBrandner Nov 12, 2022
4fbcf82
Improve typing
SimonBrandner Nov 13, 2022
1335a35
Merge branch 'develop' into matthew/sfu
dbkr Nov 16, 2022
23b3d53
Implement a very basic focus selection algorithm (#2875)
SimonBrandner Nov 29, 2022
a504a7c
Don't send member events until we're participating
SimonBrandner Nov 30, 2022
47c14c0
Merge develop
SimonBrandner Dec 4, 2022
35ad7ed
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Dec 5, 2022
f3dcdee
Remove unintentional change
SimonBrandner Dec 7, 2022
218fd23
Reduce diff
SimonBrandner Dec 7, 2022
d40c5d9
Typing
SimonBrandner Dec 8, 2022
f603f56
Remove unnecessary code
SimonBrandner Dec 8, 2022
4206df2
Remove duplicate line
SimonBrandner Dec 8, 2022
04f5c55
Remove other duplicate code
SimonBrandner Dec 8, 2022
cf28825
Futher unnecessary line removal
SimonBrandner Dec 8, 2022
d9bd7be
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Dec 8, 2022
4bdb71f
Reduce diff 1
SimonBrandner Dec 8, 2022
c57ee34
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Dec 9, 2022
8f7d6dd
Remove another unnecessary update member state
SimonBrandner Dec 9, 2022
ca12d5a
Change event shape to match MSC3898 (#2964)
SimonBrandner Dec 12, 2022
a1f763a
Fix `sdp_stream_metadata` key
SimonBrandner Dec 13, 2022
e10efc1
Fix prefixes
SimonBrandner Dec 13, 2022
41d6c9a
Delint
SimonBrandner Dec 14, 2022
01576f3
Add `getFoci()`
SimonBrandner Dec 14, 2022
3c30273
Small improvements and diff reduction
SimonBrandner Dec 14, 2022
5387c73
Make `dataChannel` `private`
SimonBrandner Dec 14, 2022
272e452
Renaming and tiny improvements
SimonBrandner Dec 14, 2022
a89a620
Re-use `onNegotiateReceived()` method
SimonBrandner Dec 14, 2022
ae2b66e
Clone streams even if we don't have to
SimonBrandner Dec 15, 2022
7ecd100
Improve logging
SimonBrandner Dec 15, 2022
243e040
Fix log line
SimonBrandner Dec 15, 2022
fd38019
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Dec 16, 2022
f7cb5b3
Mock SDP better
SimonBrandner Dec 16, 2022
77a98bf
Use `expect.objectContaining()`
SimonBrandner Dec 16, 2022
11be9ee
Mock data channel better
SimonBrandner Dec 16, 2022
3e21668
Mock `MatrixCall` better
SimonBrandner Dec 16, 2022
ce1381d
Fix method call order
SimonBrandner Dec 16, 2022
68c4dd5
Disable some tests while we figure out what to do
SimonBrandner Dec 16, 2022
6221523
Re-add replace call feed logic
SimonBrandner Dec 16, 2022
16fed17
Use `streamId` from SDP directly
SimonBrandner Dec 19, 2022
7783b24
Improve code
SimonBrandner Dec 19, 2022
d48d982
Clear feeds in `dispose()`
SimonBrandner Dec 19, 2022
108be1c
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Dec 19, 2022
3651dce
Merge remote-tracking branch 'origin/develop' into matthew/sfu
dbkr Dec 21, 2022
378cf79
Make `onCallHangup` work with focus calls
SimonBrandner Jan 6, 2023
831423a
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Jan 6, 2023
3e22076
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Jan 13, 2023
451ebfd
Add support for simulcast (#2983)
SimonBrandner Jan 25, 2023
ac97928
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Jan 25, 2023
e7c45ff
Fix `call.spec.ts`
SimonBrandner Jan 25, 2023
86d1358
Don't `setParameters()` in `updateLocalUsermediaStream()`
SimonBrandner Jan 25, 2023
62e2c7e
Clean-up simulcast code (#3106)
SimonBrandner Jan 26, 2023
523302f
Fix simulcast on chrome (#3109)
dbkr Jan 27, 2023
269761f
Retry SFU calls and refactor retry code (#3110)
SimonBrandner Jan 27, 2023
c8fed8f
Put `maxBitrate` back
SimonBrandner Jan 27, 2023
fbbee8d
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Jan 27, 2023
a429e59
Improve `maxBitrate` values
SimonBrandner Jan 27, 2023
2a4f98f
Add simulcast screensharing encodings (#3111)
SimonBrandner Jan 27, 2023
a735aae
Don't use ideal/exact in case of screen-sharing (#3112)
SimonBrandner Jan 31, 2023
61c8fb3
Don't require e2e keys for foci
dbkr Jan 31, 2023
e0a40cc
Merge pull request #3118 from matrix-org/dbkr/allow_focus_with_no_keys
dbkr Jan 31, 2023
6ee8715
Work around pion bug to fix screen sharing
dbkr Feb 2, 2023
677c1c0
More commenting
dbkr Feb 2, 2023
7ed6a04
Merge pull request #3120 from matrix-org/dbkr/screenshare_workaround
dbkr Feb 2, 2023
ae60e84
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Feb 3, 2023
262b976
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Feb 9, 2023
7cba7a1
Fix tests
SimonBrandner Feb 9, 2023
7aef8a1
Re-use transceivers for user media
dbkr Feb 10, 2023
0d97a93
Merge pull request #3144 from matrix-org/dbkr/reuse_transceiver_for_u…
dbkr Feb 10, 2023
b1757b4
Refactor `CallFeed`s (#3153)
SimonBrandner Feb 17, 2023
ba51373
Move mute state into `CallTrack`s (#3176)
SimonBrandner Feb 23, 2023
30730a6
Merge remote-tracking branch 'upstream/develop' into matthew/sfu
SimonBrandner Feb 28, 2023
30ece89
Remove nonsensical test
SimonBrandner Feb 28, 2023
97404ae
Use util
SimonBrandner Feb 28, 2023
6043a13
Use util
SimonBrandner Feb 28, 2023
7fa4294
Abstract publishing (#3183)
SimonBrandner Mar 6, 2023
363b910
Add WebRTC media stats collector (#3205)
Mar 20, 2023
bcd86c2
Exporting live WebRTC metric as GroupCall Event from SDK #3220 (#3224)
Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ out

.vscode
.vscode/
.idea
Loading