[MatrixRTC] Implement MSC4143 slots #5056
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
toger5
reviewed
Oct 30, 2025
Comment on lines
+279
to
290
| case MembershipKind.RTC: | ||
| return data.rtc_transports[0]; | ||
| case "session": | ||
| switch (data.focus_active.focus_selection) { | ||
| case "multi_sfu": | ||
| return data.foci_preferred[0]; | ||
| case "oldest_membership": | ||
| if (CallMembership.equal(this, oldestMembership)) return data.foci_preferred[0]; | ||
| if (oldestMembership !== undefined) return oldestMembership.getTransport(oldestMembership); | ||
| break; | ||
| case MembershipKind.Session: | ||
| if (data.focus_active.focus_selection === "oldest_membership") { | ||
| // For legacy events we only support "oldest_membership" | ||
| if (CallMembership.equal(this, oldestMembership)) return data.foci_preferred[0]; | ||
| if (oldestMembership !== undefined) return oldestMembership.getTransport(oldestMembership); | ||
| } | ||
| break; | ||
| } | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
In general the changes to the call membership are much more straight forward than what I anticipated. this seems to be the main functional change.
Is there anything else in the code that gets more complicated because of this?
There was a problem hiding this comment.
Not really, I only removed things which didn't break other files or ECall / EWeb. I think the conflicts with the other PRs may be high.
toger5
reviewed
Oct 30, 2025
Comment on lines
+373
to
+383
| const content = e.getContent<RtcMembershipData>(); | ||
| // Ensure the slot ID of the membership matches the state | ||
| if (content.slot_id !== slotId) { | ||
| console.log("Invalid slot ID", content.slot_id, slotId); | ||
| return false; | ||
| } | ||
| if (content.application.type !== slotDescription.application) { | ||
| console.log("Invalid application.type", content.application.type, slotDescription.application); | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Is this all covered by:
if (!deepCompare(membership.slotDescription, slotDescription))
which is done later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.