Skip to content

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Sep 30, 2025

This should help in two cases:

  • when the latest event (using the new API) is creating an aggregation, for some reason,
  • when the latest thread reply is an aggregation, for some reason.

At this, this should help with figuring out why a thread's latest reply is sometimes "unsupported", as reported in #5702

… event

This should help figuring out why some thread's latest replies are
marked as "unsupported events".
@bnjbvr bnjbvr requested a review from a team as a code owner September 30, 2025 16:17
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team September 30, 2025 16:17
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (59b7da2) to head (b52fd19).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_handler.rs 23.07% 10 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/latest_event.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5730      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.02%     
==========================================
  Files         359      359              
  Lines       99048    99051       +3     
  Branches    99048    99051       +3     
==========================================
- Hits        87566    87555      -11     
- Misses       7344     7362      +18     
+ Partials     4138     4134       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #5730 will not alter performance

Comparing bnjbvr/log-embedded-events (b52fd19) with main (59b7da2)

Summary

✅ 50 untouched

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@bnjbvr bnjbvr merged commit 681b221 into main Oct 1, 2025
53 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/log-embedded-events branch October 1, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants