feat(sdk,ui): Support edits as LatestEventValue
#5913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-sdk-latest-event-edit
branch
2 times, most recently
from
76593a9 to
d3f1b95
Compare
This patch supports any edits at a possible `LatestEventValue` candidate.
…diate previous event. This patch changes the rule of what is a `LatestEventValue` candidate in case of an edit. An edit must target/relate to its immediate previous event to be a candidate. Otherwise it's easy to edit an old message and create a “broken” `LatestEventValue` because it points to an older message that the user may not be able to find easily.
Hywan
force-pushed
the
feat-sdk-latest-event-edit
branch
from
d3f1b95 to
740811d
Compare
CodSpeed Performance ReportMerging #5913 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5913 +/- ##
==========================================
- Coverage 88.66% 88.66% -0.01%
==========================================
Files 362 362
Lines 104399 104488 +89
Branches 104399 104488 +89
==========================================
+ Hits 92569 92646 +77
- Misses 7499 7507 +8
- Partials 4331 4335 +4 ☔ View full report in Codecov by Sentry. |
Hywan
requested review from
andybalaam and
pixlwave
and removed request for
a team
Member
|
Tested on EXI, this works and I love it! 🫶 |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability for an edit (
m.room.messagewith am.relates_to+m.replace) to be considered aLatestEventValuecandidate if and only if it edits the immediate previous event. Otherwise it's easy to edit an old message and create a “broken”LatestEventValuebecause it points to an older message that the user may not be able to find easily.