Skip to content

Remove txn reader from logtail #21315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

Remove txn reader from logtail #21315

merged 4 commits into from
May 8, 2025

Conversation

aptend
Copy link
Contributor

@aptend aptend commented Jan 22, 2025 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #19475

and fix #21796
and fix #21798

What this PR does / why we need it:

  • Remove ObjectTree from TxnMemo to save memory
  • Fix disttae deadlock issue
  • Fix channel sending block issue in fault package

@aptend aptend requested a review from XuPeng-SH as a code owner January 22, 2025 02:48
@matrix-meow matrix-meow added the size/L Denotes a PR that changes [500,999] lines label Jan 22, 2025
@aptend aptend force-pushed the remove-txn-reader-from-logtail branch from ba230db to 5c92330 Compare January 22, 2025 06:01
@aptend aptend force-pushed the remove-txn-reader-from-logtail branch from 5c92330 to 5e52d10 Compare February 12, 2025 06:04
@mergify mergify bot added the kind/bug Something isn't working label May 7, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot merged commit 6c23f3f into matrixorigin:main May 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@xzxiong xzxiong xzxiong approved these changes

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@aressu1985 aressu1985 aressu1985 approved these changes

@heni02 heni02 Awaiting requested review from heni02 heni02 is a code owner

@triump2020 triump2020 Awaiting requested review from triump2020 triump2020 is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement kind/refactor Code refactor size/L Denotes a PR that changes [500,999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: UT TestGlobalCheckpoint7 timeout [Bug]: MO hung when reconnecting logtail frequently
6 participants
@aptend @zhangxu19830126 @xzxiong @XuPeng-SH @aressu1985 @matrix-meow