fix(platform-node): harden file storage - #70
Open
LukasParke wants to merge 1 commit into
Open
Conversation
|
@LukasParke is attempting to deploy a commit to the Matt Apperson's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
Author
|
Agent: The |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
__list()on an instance-local key index and batchgetMany()readsWhy
The previous filename encoding decoded literal
__as percent escapes, which could make persisted keys disappear from enumeration. Synchronous checkpoint I/O also blocked the event loop. Changing the encoder alone would orphan files written by existing releases, so reads retain a collision-safe legacy fallback and migrate legacy files without overwriting a concurrent canonical write.This semantically ports the file-storage portion of
fork/port/openrouter-fixescommitsb9905ac5and653b3986onto current main after #67 and #68. It is not a cherry-pick.createFileStorageremains single-writer-per-root forlist()consistency; this pre-existing deployment assumption is now explicit in its JSDoc.Test plan
cd packages/platform-node && bun test— 74 pass, 1 benchmark skippedcd packages/platform-node && bun run typecheckbun test— 2,058 pass, 6 integration/benchmark skipsbun run lintsentrux check .sentrux gate .Breaking behavior
None intended. Existing legacy files remain readable. Multiple live adapters pointing at the same root are not supported for
list()coherence.