Skip to content

🧪 Add test file for HoconReader - #599

Merged
matteobaccan merged 3 commits into
masterfrom
add-hocon-reader-test-16242914951724190819
Oct 1, 2026
Merged

matteobaccan merged 3 commits into
masterfrom
add-hocon-reader-test-16242914951724190819

Conversation

@matteobaccan

Copy link
Copy Markdown
Owner

🎯 What: Adds unit tests for package-private HoconReader in owner-extras.

📊 Coverage:

  • Reflection/instantiation of HoconReader's private constructor for code coverage.
  • Flattening of objects, nested lists, objects in lists, empty lists, and null values.
  • HOCON document substitutions, self-referential substitutions, and fallback on system properties.
  • Missing file IOException handling.
  • Malformed document parsing errors and verification that credentials in URIs are obscured (***@localhost).
  • Missing required substitution error handling.

✨ Result: Broad direct test coverage for HoconReader.


PR created automatically by Jules for task 16242914951724190819 started by @matteobaccan

Adds HoconReaderTest to provide direct test coverage for package-private HoconReader.
Covers constructor reflection, document flattening, list parsing, substitutions,
system property fallbacks, credential hiding, and error handling for malformed input
and missing required substitutions.

Co-authored-by: matteobaccan <200925+matteobaccan@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

matteo baccan added 2 commits October 1, 2026 12:38
Concatenating an absolute path after the authority breaks on Windows,
where the path starts with a drive letter instead of a slash.
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@matteobaccan
matteobaccan merged commit 225f564 into master Oct 1, 2026
25 of 26 checks passed
@matteobaccan
matteobaccan deleted the add-hocon-reader-test-16242914951724190819 branch October 1, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant