Skip to content

🛡️ Sentinel: Fix timing side-channel in RsaHandler.equals - #629

Open
matteobaccan wants to merge 1 commit into
masterfrom
sentinel/rsa-handler-constant-time-equals-5556616144509421197
Open

matteobaccan wants to merge 1 commit into
masterfrom
sentinel/rsa-handler-constant-time-equals-5556616144509421197

Conversation

@matteobaccan

Copy link
Copy Markdown
Owner

🛡️ Sentinel Security Fix:

  • Severity: HIGH
  • Vulnerability: Timing side-channel vulnerability in key fingerprint comparison in RsaHandler.equals.
  • Impact: Non-constant-time byte comparison using Arrays.equals short-circuits upon the first mismatched byte, allowing an attacker to execute timing attacks to deduce key fingerprint bytes.
  • Fix: Replaced java.util.Arrays.equals with java.security.MessageDigest.isEqual to enforce constant-time equality checks for key fingerprints.
  • Verification: Ran test suite with mvn test -pl owner, all 1701 tests pass cleanly.

PR created automatically by Jules for task 5556616144509421197 started by @matteobaccan

Use MessageDigest.isEqual instead of Arrays.equals for fingerprint
comparison in RsaHandler.equals to prevent timing side-channel attacks.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant