Repository navigation
🛡️ Sentinel: Fix timing side-channel in RsaHandler.equals - #629
matteobaccan wants to merge 1 commit into
Conversation
Use MessageDigest.isEqual instead of Arrays.equals for fingerprint comparison in RsaHandler.equals to prevent timing side-channel attacks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|



🛡️ Sentinel Security Fix:
RsaHandler.equals.Arrays.equalsshort-circuits upon the first mismatched byte, allowing an attacker to execute timing attacks to deduce key fingerprint bytes.java.util.Arrays.equalswithjava.security.MessageDigest.isEqualto enforce constant-time equality checks for key fingerprints.mvn test -pl owner, all 1701 tests pass cleanly.PR created automatically by Jules for task 5556616144509421197 started by @matteobaccan