Repository navigation
🛡️ Sentinel: Enforce secure processing on SAXParser in XMLLoader - #633
matteobaccan wants to merge 1 commit into
Conversation
Explicitly set FEATURE_SECURE_PROCESSING on SAXParser instances created in XMLLoader.read() to ensure secure processing limits are enforced at the parser level as defense-in-depth against XML entity expansion / XXE DoS.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This branch has not been deployed
1 participant
🛡️ Sentinel Security Improvement
XMLConstants.FEATURE_SECURE_PROCESSINGat the parser instance level in addition to the factory level to protect against misconfigured or custom SAX parser implementations.setFeature(SAXParser parser, String feature, boolean value)helper and invokedsetFeature(parser, XMLConstants.FEATURE_SECURE_PROCESSING, true)insideXMLLoader.read().testSecureProcessingPropertyIsSetOnParserinXMLLoaderTest.javaand ran full suite viamvn test.PR created automatically by Jules for task 8508956137073353673 started by @matteobaccan