Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback for gid and uid lookup #1

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ktmeaton
Copy link
Contributor

This pull request adds fallback values for group and user on systems where the lookup fails. I'm not sure if this is actually a good idea, but I'd guess that ls does something similar.

@mattheww95
Copy link
Owner

I have been going through the coreutils code and I am still not quite sure what exactly is responsible for getting the gid when it is not in /etc/groups but I think in this case a solution is better than nothing even if there are edge cases.

Thank you so much for fixing this, It has given me some additional reading as well. I did not know you could write literal c strings in rust like you did.

Thanks so much once again!

@mattheww95 mattheww95 merged commit 0f64bc8 into mattheww95:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants