Only use strftime if in browser environment, for use in Node.js#46
Open
tomblanchard wants to merge 2 commits intomattmccray:masterfrom
Open
Only use strftime if in browser environment, for use in Node.js#46tomblanchard wants to merge 2 commits intomattmccray:masterfrom
tomblanchard wants to merge 2 commits intomattmccray:masterfrom
Conversation
Owner
|
Does this still build correctly and pass all the tests? |
Author
|
@mattmccray Sure does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using liquid.js in a Node.js environment and am getting the
document is not definederror when compiling templates due to strftime relying on the DOM,documentdoesn't exist in Node.js, my changes make is sostrftimeis used only whenwindowis present (i.e. in a browser environment).