Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chart colors #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

DogPawHat
Copy link
Contributor

see https://ui.shadcn.com/docs/components/chart#using-colors

Colors can be changed with the chart variables in tailwind.css

Screenshot 2025-02-20 161810

Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 16e0da8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evalite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 2:22pm

@mattpocock
Copy link
Owner

I think I'm happy with the blue that's there already - was there a rationale behind changing the colour to red?

@DogPawHat
Copy link
Contributor Author

It's the default shadcn colors as it turns out. I can patch the variables in the tailwind config back to blue.

@mattpocock
Copy link
Owner

Yeah let's keep it blue. But - nice, don't want to rely on the implicit defaults

see https://ui.shadcn.com/docs/components/chart#using-colors

Colors can be changed with the `chart` varaibles in tailwind.css
@DogPawHat
Copy link
Contributor Author

Got the blue converted to hsl and chucked it in the tailwind.css as chart-1. Deleated the other chart values that came with shadcn - we can add more with a pattete picker like https://medialab.github.io/iwanthue/ if we need extra charts

*example palette:

[[354,65.442,55.888],
[290,66.44,55.066],
[338,69.251,57.743],
[310,70.709,56.371],
[323,70.625,59.318]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants