This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Video/Audio Machine #51
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the #47 issue, here's the pull request for the Video/Audio controls machine.
I still think there's a lot of room for improvement in this machine. I'd love to receive some feedback.
A few ideas that I think could be discussed:
ready
state foridle
. There might be some use cases where people want to load the content but not auto-play it.seek
.