Skip to content

[StepSecurity] Apply security best practices #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauriciomenon merged 2 commits into from
May 12, 2026
Merged

[StepSecurity] Apply security best practices #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c70051
[StepSecurity] Apply security best practices
stepsecurity-app[bot] May 3, 2026
7473b73
Merge branch 'master' into chore/GHA-031126-stepsecurity-remediation
mauriciomenon May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/secret_scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Harden the runner (Audit all outbound calls)
uses: step-security/harden-runner@a5ad31d6a139d249332a2605b85202e8c0b78450 # v2.19.1
with:
egress-policy: audit
Comment on lines +20 to +23

@llamapreview llamapreview Bot May 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: Medium

The egress-policy is set to audit, which logs outbound calls but does not block any network traffic. For a security-focused workflow, auditing alone may provide limited protection against credential exfiltration or supply-chain attacks. The documentation for harden-runner recommends moving to block mode (with an allowed endpoint list) after verifying the workflow’s network requirements. Setting egress-policy: audit is a safe initial step, but the PR should include a comment or follow-up task to transition to block once the allowed endpoints are validated. Without this, the security benefit of the runner hardening is reduced to observability only, leaving the CI pipeline still susceptible to malicious outbound calls.

Code Suggestion:

- name: Harden the runner (Audit all outbound calls)
        uses: step-security/harden-runner@a5ad31d6a139d249332a2605b85202e8c0b78450 # v2.19.1
        with:
          egress-policy: block   # Future: change to 'audit' when testing new endpoints
          allowed-endpoints: > #
            api.github.com:443
            github.com:443
            objects.githubusercontent.com:443


- name: Checkout repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
Expand Down
Loading