Skip to content

Conversation

@UiP9AV6Y
Copy link
Contributor

filesystem implementation usable for scenarios where consumers request resources with their hashed name.

@UiP9AV6Y
Copy link
Contributor Author

the example project in this MR depends on #2 as it calls hashets with -code-only

i can also create a dedicated MR for the example project in order to keep the focus of this MR on the implementation of HashFS

Copy link
Owner

@mavolin mavolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the time you took writing the example. Therefore I feel bad for saying this, but I feel the example is just too big (9 files) to be sensible. I realise there are people who prefer thorough examples, but I think if you were to add this method of hashing to the readme and quickly explain the tradeoffs/benefits compared to the other methods (mimicking the style of the other examples), it would prove just as valueable.

I think this has two advantages:

  1. Since there are no examples for the other methods of hashing, people might overlook this example.
  2. The examples in the readme are much shorter and can hence be understood in far less time. I've had the experience that mini-project examples like this take far more time to understand, since there is no "guiding hand" that explains the idea; whereas the readme can sort of "narrate" what is happening, often requiring less code and therefore less effort to understand the idea behind this example.

I'm obviously fine HashFS itself.

@UiP9AV6Y UiP9AV6Y changed the title feat(hashets): add HashFS feat(hashets): add WrapPrecomputedFS Aug 30, 2025
@UiP9AV6Y
Copy link
Contributor Author

i have remove the example app and instead added an additional section to the README.md explaining the usecase and drawbacks

Copy link
Owner

@mavolin mavolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good renaming, thank you for readme section. Some minor changes for clarity, and then we have it. :)

`WrapFS` implementation where the mappings are compute elsewhere,
e.g. during build time.
@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.64%. Comparing base (ed6b867) to head (ab4c46f).
⚠️ Report is 10 commits behind head on v1.

Additional details and impacted files
@@             Coverage Diff             @@
##               v1       #3       +/-   ##
===========================================
+ Coverage   27.58%   57.64%   +30.06%     
===========================================
  Files           5        3        -2     
  Lines         348      170      -178     
===========================================
+ Hits           96       98        +2     
+ Misses        231       51      -180     
  Partials       21       21               
Flag Coverage Δ
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mavolin mavolin merged commit 4ef68c7 into mavolin:v1 Aug 31, 2025
5 checks passed
@mavolin
Copy link
Owner

mavolin commented Aug 31, 2025

@UiP9AV6Y thank you for your PRs, I've created a release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants